Alter table add column #1186
Merged
Alter table add column #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
requested changes
Jan 17, 2023
src/storage/store/rel_table.cpp
Outdated
| @@ -341,6 +341,11 @@ void RelTable::initEmptyRelsForNewNode(nodeID_t& nodeID) { | |||
| listsUpdatesStore->initNewlyAddedNodes(nodeID); | |||
| } | |||
|
|
|||
| void RelTable::addProperty(Property property, TableSchema* tableSchema) { | |||
| fwdRelTableData->addProperty(property, tableSchema, wal, bufferManager); | |||
There was a problem hiding this comment.
You can pass wal and bufferManager as private fields to DirectedRelTableData, so you don't need to pass them here.
There was a problem hiding this comment.
WAL is also used by relTable, so we need to store WAL in relTable. I don't think it is a good idea to store it in DirectedRelTableData as well.
| @@ -222,6 +222,31 @@ void InMemOverflowFile::copyListOverflow(InMemOverflowFile* srcInMemOverflowFile | |||
| dstKUList->size * numBytesOfListElement); | |||
| } | |||
|
|
|||
| void InMemOverflowFile::copyListOverflow( | |||
There was a problem hiding this comment.
This function has potential deadlocks. See #1112
andyfengHKU
reviewed
Jan 18, 2023
acquamarin
force-pushed
the
add-property
branch
3 times, most recently
from
709e1a9
to
67dba6c
Compare
ray6080
approved these changes
Jan 19, 2023
acquamarin
force-pushed
the
add-property
branch
from
67dba6c
to
1de5fd0
Compare
ray6080
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding column to an existing node/rel table.
The grammar for adding column is:
ALTER TABLE person ADD COLUMN count INTEGER DEFAULT 25;If the user doesn't give a default value, the newly added column will be filled with null values.