Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete node/rel properties without transactions #1169

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

acquamarin
Copy link
Collaborator

  1. This PR adds support for deleting node/rel propties. (Without supporting transaction).
  2. Refactors the copy_csv/drop_table operators.
  3. Breaks the assumption that the propertyID must be consecutive of a table since we allow user removing a property from a table now.

src/include/parser/ddl/drop_column.h Outdated Show resolved Hide resolved
src/include/parser/ddl/drop_column.h Outdated Show resolved Hide resolved
src/include/binder/bind/bound_drop_column.h Outdated Show resolved Hide resolved
src/include/common/statement_type.h Outdated Show resolved Hide resolved
src/binder/expression_binder.cpp Outdated Show resolved Hide resolved
src/storage/store/rel_table.cpp Outdated Show resolved Hide resolved
src/storage/store/rel_table.cpp Show resolved Hide resolved
src/storage/store/rel_table.cpp Outdated Show resolved Hide resolved
src/storage/wal_replayer.cpp Outdated Show resolved Hide resolved
src/storage/wal_replayer_utils.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit d206fa8 into master Jan 11, 2023
@acquamarin acquamarin deleted the drop-col branch January 11, 2023 08:36
@ray6080 ray6080 changed the title add support for deleting property Delete node/rel properties without transactions Jan 29, 2023
@ray6080 ray6080 added the feature New features or missing components of existing features label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or missing components of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants