Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node map agg #1160

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Node map agg #1160

merged 1 commit into from
Jan 9, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR allows returning node/rel as all of their properties aggregated in json format in a single column. To do so, this PR

  • Add BoundStatementResult which defines the schema of how to aggregate multiple columns into a single column in json format
  • Move ownership of iterate tuple from iterator to query result. So iterator only writes to a vector of flat values.

Other changes

  • Move isReadOnly, isDDL, isCopyCSV check from planning stage to binding stage
  • Alter preparedStatement to take a vector of logical plans and thus remove APIs exposed only for testing framework

@andyfengHKU andyfengHKU marked this pull request as ready for review January 8, 2023 13:23
test/test_files/tinysnb/projection/single_label.test Outdated Show resolved Hide resolved
src/include/binder/binder.h Outdated Show resolved Hide resolved
src/include/binder/bound_statement_result.h Show resolved Hide resolved
src/include/main/prepared_statement.h Show resolved Hide resolved
src/include/main/query_result.h Show resolved Hide resolved
src/include/processor/mapper/plan_mapper.h Show resolved Hide resolved
src/include/processor/physical_plan.h Show resolved Hide resolved
src/include/processor/result/factorized_table.h Outdated Show resolved Hide resolved
src/include/processor/result/value.h Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 70fc9e1 into master Jan 9, 2023
@andyfengHKU andyfengHKU deleted the node-map-agg branch January 9, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants