Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor benchmark script #1151

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Refactor benchmark script #1151

merged 1 commit into from
Jan 5, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Jan 4, 2023 •
edited
Loading

This PR refactors the benchmark script:

  • Automatically keep track of the version from CMakeLists.txt file. On version change, the script automatically serialize the dataset.
  • Dockerize for easier deployment.
  • Decouple the database and file storage. Submit the result via REST API instead.
  • Factor out several hard-coded configuration variables as env variables for better parameter passing.
  • Automatically detect CPU core count and memory size to configure the runner accordingly.

@mewim mewim force-pushed the benchmark-refactor branch 3 times, most recently from 24b6ff7 to d99c72e Compare January 5, 2023 09:38
@mewim mewim marked this pull request as ready for review January 5, 2023 09:39
@mewim mewim merged commit 6ae651c into master Jan 5, 2023
@mewim mewim deleted the benchmark-refactor branch January 5, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

@acquamarin acquamarin Awaiting requested review from acquamarin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mewim @ray6080