Update rel property #1149
Merged
Update rel property #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semihsalihoglu-uw
requested changes
Jan 4, 2023
test/runner/e2e_update_rel_test.cpp
Outdated
| } | ||
|
|
||
| TEST_F(UpdateRelTest, UpdateNewlyInsertedEdges) { | ||
| ASSERT_TRUE(conn->query(getInsertKnowsRelQuery( |
There was a problem hiding this comment.
I am not sure what this tests if each of these insert queries run as a separate transaction and checkpoints. Let's discuss this.
There was a problem hiding this comment.
Added the conn->startWriteTrx() at the beginning of this test.
src/include/storage/storage_structure/lists/lists_update_store.h
Outdated
Show resolved
Hide resolved
src/include/storage/storage_structure/lists/lists_update_store.h
Outdated
Show resolved
Hide resolved
semihsalihoglu-uw
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the backend to update a property of an existing rel.
PersistentStoreUpdateswhich stores the updates to a list. When the user tries to read the updated list, thelists:readValues()function will callreadUpdatesToVectorIfExistswhich updates the vector with the updated values inPersistentStoreUpdates.listsUpdateStore->relUpdateStore, and refactors some functions.