Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow node copier #1146

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Arrow node copier #1146

merged 1 commit into from
Jan 6, 2023

Conversation

printfCalvin
Copy link
Contributor

  • Switching kuzu's own node CSV reader to apache arrow.
  • Fixing test files to follow the CSV standard.
  • Fixing assertion failure when reading an empty list.

ray6080
ray6080 requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unresolved messages regarding to merging/squashing. Can you clean those first? I will look into the code after you clean those out.

README.md Outdated Show resolved Hide resolved
dataset/copy-csv-node-property-test/vPerson.csv Outdated Show resolved Hide resolved
dataset/tinysnb/vPerson.csv Outdated Show resolved Hide resolved
src/binder/bind/bind_ddl.cpp Outdated Show resolved Hide resolved
@printfCalvin printfCalvin force-pushed the arrow_master_squashed branch 6 times, most recently from 4f84fce to 85cb62f Compare January 3, 2023 19:58
@ray6080 ray6080 force-pushed the arrow_master_squashed branch 3 times, most recently from b018d8e to a1162c5 Compare January 5, 2023 23:02
@ray6080 ray6080 force-pushed the arrow_master_squashed branch 3 times, most recently from 03152ff to fa316f7 Compare January 6, 2023 05:53
mewim
mewim requested changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile does not seem to be reverted correctly. @ray6080 could you please revert this before merging the PR?

benchmark/Dockerfile Show resolved Hide resolved
@ray6080 ray6080 merged commit 9ac17d2 into master Jan 6, 2023
@ray6080 ray6080 deleted the arrow_master_squashed branch January 6, 2023 15:48
@ray6080 ray6080 changed the title Arrow node implementation Arrow node copier Jan 29, 2023
@ray6080 ray6080 added the feature New features or missing components of existing features label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

@mewim mewim mewim approved these changes

@weipang142857 weipang142857 Awaiting requested review from weipang142857

Assignees
No one assigned
Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@printfCalvin @ray6080 @mewim