Fix issue 1033 #1145
Merged
Fix issue 1033 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
requested changes
Jan 3, 2023
|
added python & cpp api tests |
andyfengHKU
reviewed
Jan 4, 2023
| @@ -1,4 +1,7 @@ | |||
| import pytest | |||
| import sys | |||
| sys.path.append('../build/') | |||
There was a problem hiding this comment.
double check if this is needed.
There was a problem hiding this comment.
yes seems to be required, the tests failed after I removed it: https://github.com/kuzudb/kuzu/actions/runs/3838919604/jobs/6535990703
andyfengHKU
approved these changes
Jan 4, 2023
ray6080
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1033 added a try catch block to handle incorrect database path directory