Wrap pybind11 API and and Fix #1106 #1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
query_result.py
, the__del__
method is added, which will close the query result automatically.query_result.py
, a reference toconnection
is added. This ensures that when the garbage collection is invoked for theconnection
, the corresponding query results have to be deleted first.database
is added to the connection. Overall, the above measurements ensures the garbage collection order of query result -> connection -> database to prevent the memory leak caused by database being closed first.test_query_result_close.py
). Note that the issue is not reproducible inpytest
. Therefore, this script invokes a new Python process. It is verified that without the above measurements, this test script does fail.query_result.py
to usesneak_case
in accordance with the Python standard.