Extend property reading #1108
Merged
Extend property reading #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
The general comment is we should rename our scan operators to be more accurate.
Suggestions:
AdjColumnExtend -> ScanRelTableColumns
AdjListExtend -> ScanRelTableLists
GenericExtend -> ScanGenericRelTable
ScanSingleTableProperties -> ScanSingleNodeTable
ScanMultiTableProperties -> ScanMultiNodeTable
andyfengHKU
force-pushed
the
extend-property-reading
branch
from
35eeb54
to
833ea93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts BaseExtend class to make sure all of our extends (i.e. ColumnExtend, ListExtend, GenericExtend) have the same behaviour.
We read all rel properties together with extend to avoid appending listSyncState to resultSet. Also this simplifies our design of GenericExtend. The tricky part is that it's hard to elegantly sync list state between GenericExtend and GenericScanRelProperty. So we choose this simpler design until we have a better solution to read rel properties.
A hidden bug related to scan rel property after deletion can be found at adjList_extend.cpp