Remove getPositionOfCurrIdx
#1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Dec 6, 2022
ray6080
force-pushed
the
remove-is-flat
branch
from
050c0f0
to
5427756
Compare
ray6080
force-pushed
the
remove-is-flat
branch
from
5427756
to
9b39143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to solve issue #744 .
This PR removes the use of
getPositionOfCurrIdx(), which is a specialized interface to get selected pos of a flat state.The goal of this and the following PRs is to remove the concept of
flat/unflatin the backend, so the front end still keeps track of flat and unflat for factorized structures, while the backend only needs to differentiate the cardinality of 1 and N.For any two vectors with two different states, we allow computation over the cartesian product of 1 X N, 1 X 1 and N X 1.
For N X N, it is only allowed for two vectors with the same state.