Unlabeled rel in match patterns #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
approved these changes
Dec 2, 2022
ray6080
reviewed
Dec 2, 2022
There was a problem hiding this comment.
The general comment is, as we discussed, in the next PR, we can try the idea of only having a single generic scan operator for all rel nodeIDs and properties. This can simplify sync states, and if it works fine, we shall propagate this to all scans (with filter pushdown) later.
I'd hold onto doing this next PR given our priorities now. |
andyfengHKU
force-pushed
the
unlabeled-rel
branch
from
53d0518
to
0d73d01
Compare
ray6080
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to support unlabeled rel