Scan rel ID blindly #1074
Merged
Scan rel ID blindly #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
approved these changes
Nov 28, 2022
andyfengHKU
force-pushed
the
scan-rel-id
branch
from
2255244
to
fee58f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are supporting rel deletion and property setting, we need to scan rel ID (unique identifier) blindly to make sure we can scan local store property.
This PR adds rel ID scanning for each rel extend by storing internal ID with node/rel variable together. This helps us to move towards a principal that all property binding (i.e. column binding) should happen in binder. No other components is allowed to perform any kind of binding.