Add setValue and getValue for ValueVector #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Nov 18, 2022
test/processor/physical_plan/operator/orderBy/order_by_key_encoder_test.cpp
Show resolved
Hide resolved
ray6080
force-pushed
the
unified-vector-loop
branch
3 times, most recently
from
97ece09
to
aecaacb
Compare
ray6080
force-pushed
the
unified-vector-loop
branch
from
aecaacb
to
5552c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
valuesinValueVector, instead: (1) expose templated get/setValue interface with a given data type; (2) expose getData() for cases we need access to raw pointers, e.g., need to reference a value inside the vector; memcpy values into/out of the ValueVector, etc.Removed
using namespace stdfromtypes.h.Removed the exception test for "MATCH", which crashes on MacOS due to error signals.