Rework srcDstTableID #1041
Merged
Rework srcDstTableID #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
approved these changes
Nov 18, 2022
acquamarin
force-pushed
the
srcDstTableIDRefactor
branch
from
420a22a
to
f92f524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the srcDstTableID.
Instead of storing two unordered sets of src/dst tableIDs, we now store a vector of <srcTableID, dstTableID> pairs.
With the new design of srcDstTableID, we now can support more generic relations. (eg. we can have a manages rel table whose relation is: president->manager, manager->worker).