Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 967 #1040

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix issue 967 #1040

merged 1 commit into from
Nov 18, 2022

Conversation

aziz-mu
Copy link
Contributor

@aziz-mu aziz-mu commented Nov 17, 2022 •
edited
Loading

Added ability to customize delimiter, escape character, and newline when writing to CSV files from both the C++ and the python api. Also, added tests for both the C++ and python APIs.

This fixes issue #967

@aziz-mu aziz-mu requested review from acquamarin and mewim and removed request for acquamarin November 17, 2022 17:00
acquamarin
acquamarin reviewed Nov 17, 2022
View reviewed changes
src/main/query_result.cpp Outdated Show resolved Hide resolved
src/main/query_result.cpp Show resolved Hide resolved
tools/python_api/py_query_result.cpp Show resolved Hide resolved
mewim
mewim approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are fine. @aziz-mu can you try to add a test case which uses pandas to read your output file to make sure it works properly with the customization?

@aziz-mu aziz-mu merged commit ada100c into master Nov 18, 2022
@aziz-mu aziz-mu deleted the CSV-write branch November 18, 2022 19:09
@ray6080 ray6080 changed the title added custom specifiers to writeCSV Fix issue 967 Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acquamarin acquamarin acquamarin left review comments

@mewim mewim mewim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aziz-mu @mewim @acquamarin