Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a version number for the serialization format #422

Closed
semihsalihoglu-uw opened this issue Dec 19, 2021 · 1 comment
Closed

Keep a version number for the serialization format #422

semihsalihoglu-uw opened this issue Dec 19, 2021 · 1 comment
Labels
feature New features or missing components of existing features

Comments

@semihsalihoglu-uw
Copy link
Contributor

Currently if we try to load a serialized graph that is stale or not exactly in the format the system expects, during starting up of a shell (and later other applications) will hang. We should instead have a versioning system for our serialization formats. Ideally, the version numbers would be automatically generated, instead of us writing a manual version number each time we change the loader but I don't know if this is possible/easy to do. And then during shell startup, we should check if the version of the serialized db is what the system expects and if not should error (instead of hanging).

@semihsalihoglu-uw semihsalihoglu-uw added the feature New features or missing components of existing features label Dec 19, 2021
@acquamarin
Copy link
Collaborator

Solved in #1436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or missing components of existing features
Projects
None yet
Development

No branches or pull requests

3 participants