Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with VS2019 due to error C3855 #3022

Closed
mewim opened this issue Mar 11, 2024 · 0 comments
Closed

Build fails with VS2019 due to error C3855 #3022

mewim opened this issue Mar 11, 2024 · 0 comments
Assignees
@benjaminwinger
Labels
compiler Issues related to building from source files, clang-tidy, and other compiler tech

Comments

@mewim
Copy link
Member

mewim commented Mar 11, 2024 •
edited by prrao87
Loading

See https://github.com/kuzudb/kuzu/actions/runs/8229430092/job/22500623754

The compilation fails on VS2019 due to:

error C3855: 'kuzu::storage::HashIndexBuilder<T,S>': template parameter 'T' is incompatible with the declaration

We should either fix this for VS2019 or update the docs to reflect that we require VS2022 at least on Winodws.
@mewim mewim added the compiler Issues related to building from source files, clang-tidy, and other compiler tech label Mar 11, 2024
@mewim mewim mentioned this issue Mar 12, 2024
Merged
benjaminwinger added a commit that referenced this issue Mar 12, 2024
@benjaminwinger
Use just one template type for HashIndexBuilder and remove the constr…
4fbaff3 
…aint

The constraint seems to cause issues with MSVC 19.27 (#3022)
@benjaminwinger benjaminwinger mentioned this issue Mar 12, 2024
Merged
benjaminwinger added a commit that referenced this issue Mar 12, 2024
@benjaminwinger
Remove the constraint on the HashIndexBuilder template parameter
21bda9c 
The constraint seems to cause issues with MSVC 19.27 (#3022)
benjaminwinger added a commit that referenced this issue Mar 13, 2024
@benjaminwinger
Remove the constraint on the HashIndexBuilder template parameter
b304389 
The constraint seems to cause issues with MSVC 19.27 (#3022)
@mewim mewim closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminwinger benjaminwinger

Labels
compiler Issues related to building from source files, clang-tidy, and other compiler tech
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminwinger @mewim