Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master test open too many files #2894

Closed
andyfengHKU opened this issue Feb 15, 2024 · 1 comment · Fixed by #2895
Closed

Master test open too many files #2894

andyfengHKU opened this issue Feb 15, 2024 · 1 comment · Fixed by #2895
Assignees
Labels
bug Something isn't working

Comments

@andyfengHKU
Copy link
Contributor

andyfengHKU commented Feb 15, 2024

My local machine has ulimit 256 and when I run make test it starts complaining too many opened files. I assume this partially because we open 64 files in order to parallel hash index. But still 256 should be sufficient to run tests.

P.S. I'm labelling this as a bug for now. Feel free to change if this is expected.

@andyfengHKU andyfengHKU added the bug Something isn't working label Feb 15, 2024
@benjaminwinger
Copy link
Collaborator

This was a regression in #2857. I overlooked that the InMemFile used for storing strings independently opens the file for writing, so going from one to 256 of them meant it's now opening 256 files. It shouldn't be an issue for them to share a file descriptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants