Merge pull request #1744 from kuzudb/fix-in-query-call

fix in query call op bug
kuzudb · Jun 30, 2023 · e704660 · e704660
2 parents 8172ee7 + 93a7e37
commit e704660
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/include/processor/operator/call/in_query_call.h b/src/include/processor/operator/call/in_query_call.h
@@ -14,11 +14,6 @@ struct InQueryCallSharedState {
 
     explicit InQueryCallSharedState(common::offset_t maxOffset) : maxOffset{maxOffset} {}
 
-    inline bool hasNext() {
-        std::lock_guard guard{mtx};
-        return offset < maxOffset;
-    }
-
     std::pair<common::offset_t, common::offset_t> getNextBatch();
 };
 

diff --git a/src/processor/operator/call/in_query_call.cpp b/src/processor/operator/call/in_query_call.cpp
@@ -17,13 +17,14 @@ void InQueryCall::initLocalStateInternal(ResultSet* resultSet, ExecutionContext*
 }
 
 bool InQueryCall::getNextTuplesInternal(kuzu::processor::ExecutionContext* context) {
-    if (sharedState->hasNext()) {
-        auto morsel = sharedState->getNextBatch();
+    auto morsel = sharedState->getNextBatch();
+    if (morsel.second > morsel.first) {
         inQueryCallInfo->tableFunc(morsel, inQueryCallInfo->bindData.get(), outputVectors);
         metrics->numOutputTuple.increase(morsel.second - morsel.first);
         return true;
+    } else {
+        return false;
     }
-    return false;
 }
 
 } // namespace processor