Fix SHA256

kuzudb · Apr 4, 2024 · c7f62df · c7f62df
1 parent d435780
commit c7f62df
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/src/common/sha256.cpp b/src/common/sha256.cpp
@@ -24,18 +24,7 @@ void SHA256::addString(const std::string& str) {
     }
 }
 
-std::string SHA256::finalize() {
-    std::string hash;
-    hash.resize(SHA256_HASH_LENGTH_BYTES);
-
-    if (mbedtls_sha256_finish(&shaContext, reinterpret_cast<unsigned char*>(hash.data()))) {
-        throw RuntimeException{"SHA256 Error"};
-    }
-
-    return hash;
-}
-
-void SHA256::finishHex(char* out) {
+void SHA256::finishSHA256(char* out) {
     std::string hash;
     hash.resize(SHA256_HASH_LENGTH_BYTES);
 

diff --git a/src/include/common/sha256.h b/src/include/common/sha256.h
@@ -16,8 +16,7 @@ class SHA256 {
     SHA256();
     ~SHA256();
     void addString(const std::string& str);
-    std::string finalize();
-    void finishHex(char* out);
+    void finishSHA256(char* out);
     static void toBase16(const char* in, char* out, size_t len);
 
 private:

diff --git a/src/include/function/hash/functions/sha256_function.h b/src/include/function/hash/functions/sha256_function.h
@@ -15,7 +15,7 @@ struct SHA256Operator {
 
         SHA256 hasher;
         hasher.addString(operand.getAsString());
-        hasher.finishHex(reinterpret_cast<char*>(result.getDataUnsafe()));
+        hasher.finishSHA256(reinterpret_cast<char*>(result.getDataUnsafe()));
     }
 };