Merge pull request #1897 from kuzudb/binder-reorg

re-organize binder module
kuzudb · Aug 6, 2023 · b03de04 · b03de04
2 parents 68e86ef + dc36893
commit b03de04
Show file tree

Hide file tree

Showing 30 changed files with 25 additions and 33 deletions.
diff --git a/src/binder/CMakeLists.txt b/src/binder/CMakeLists.txt
@@ -10,6 +10,7 @@ add_library(kuzu_binder
         bound_statement_result.cpp
         bound_statement_visitor.cpp
         expression_binder.cpp
+        expression_visitor.cpp
         query_normalizer.cpp)
 
 set(ALL_OBJECT_FILES

diff --git a/src/binder/bind/bind_create_macro.cpp b/src/binder/bind/bind_create_macro.cpp
@@ -1,5 +1,5 @@
 #include "binder/binder.h"
-#include "binder/macro/bound_create_macro.h"
+#include "binder/bound_create_macro.h"
 #include "common/string_utils.h"
 #include "parser/create_macro.h"
 

diff --git a/src/binder/bind/bind_projection_clause.cpp b/src/binder/bind/bind_projection_clause.cpp
@@ -1,6 +1,6 @@
 #include "binder/binder.h"
-#include "binder/expression/expression_visitor.h"
 #include "binder/expression/literal_expression.h"
+#include "binder/expression_visitor.h"
 #include "parser/expression/parsed_property_expression.h"
 
 using namespace kuzu::common;

diff --git a/src/binder/bind/bind_reading_clause.cpp b/src/binder/bind/bind_reading_clause.cpp
@@ -1,6 +1,6 @@
 #include "binder/binder.h"
-#include "binder/call/bound_in_query_call.h"
 #include "binder/expression/literal_expression.h"
+#include "binder/query/reading_clause/bound_in_query_call.h"
 #include "binder/query/reading_clause/bound_unwind_clause.h"
 #include "parser/query/reading_clause/in_query_call_clause.h"
 #include "parser/query/reading_clause/unwind_clause.h"

diff --git a/src/binder/bind/bind_standalone_call.cpp b/src/binder/bind/bind_standalone_call.cpp
@@ -1,5 +1,5 @@
 #include "binder/binder.h"
-#include "binder/call/bound_standalone_call.h"
+#include "binder/bound_standalone_call.h"
 #include "parser/standalone_call.h"
 
 namespace kuzu {

diff --git a/src/binder/expression/CMakeLists.txt b/src/binder/expression/CMakeLists.txt
@@ -3,7 +3,6 @@ add_library(
         OBJECT
         case_expression.cpp
         expression.cpp
-        expression_visitor.cpp
         function_expression.cpp)
 
 set(ALL_OBJECT_FILES

diff --git a/src/binder/expression_binder.cpp b/src/binder/expression_binder.cpp
@@ -1,10 +1,10 @@
 #include "binder/expression_binder.h"
 
 #include "binder/binder.h"
-#include "binder/expression/expression_visitor.h"
 #include "binder/expression/function_expression.h"
 #include "binder/expression/literal_expression.h"
 #include "binder/expression/parameter_expression.h"
+#include "binder/expression_visitor.h"
 #include "function/cast/vector_cast_functions.h"
 
 using namespace kuzu::common;

diff --git a/src/binder/expression/expression_visitor.cpp → src/binder/expression_visitor.cpp b/src/binder/expression/expression_visitor.cpp → src/binder/expression_visitor.cpp
@@ -1,4 +1,4 @@
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 
 #include "binder/expression/case_expression.h"
 #include "binder/expression/existential_subquery_expression.h"

diff --git a/src/binder/expression_visitor/CMakeLists.txt b/src/binder/expression_visitor/CMakeLists.txt
diff --git a/src/binder/query/query_graph.cpp b/src/binder/query/query_graph.cpp
@@ -1,6 +1,6 @@
-#include "binder/query/reading_clause/query_graph.h"
+#include "binder/query/query_graph.h"
 
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 
 namespace kuzu {
 namespace binder {

diff --git a/src/binder/visitor/property_collector.cpp b/src/binder/visitor/property_collector.cpp
@@ -1,6 +1,6 @@
 #include "binder/visitor/property_collector.h"
 
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 #include "binder/query/reading_clause/bound_match_clause.h"
 #include "binder/query/reading_clause/bound_unwind_clause.h"
 #include "binder/query/updating_clause/bound_create_clause.h"

diff --git a/...include/binder/macro/bound_create_macro.h → src/include/binder/bound_create_macro.h b/...include/binder/macro/bound_create_macro.h → src/include/binder/bound_create_macro.h
diff --git a/...clude/binder/call/bound_standalone_call.h → src/include/binder/bound_standalone_call.h b/...clude/binder/call/bound_standalone_call.h → src/include/binder/bound_standalone_call.h
diff --git a/...de/binder/expression/expression_visitor.h → src/include/binder/expression_visitor.h b/...de/binder/expression/expression_visitor.h → src/include/binder/expression_visitor.h
diff --git a/src/include/binder/query/normalized_query_part.h b/src/include/binder/query/normalized_query_part.h
@@ -1,9 +1,9 @@
 #pragma once
 
 #include "binder/query/reading_clause/bound_unwind_clause.h"
-#include "binder/query/reading_clause/query_graph.h"
 #include "binder/query/return_with_clause/bound_projection_body.h"
 #include "binder/query/updating_clause/bound_updating_clause.h"
+#include "query_graph.h"
 
 namespace kuzu {
 namespace binder {

diff --git a/...binder/query/reading_clause/query_graph.h → src/include/binder/query/query_graph.h b/...binder/query/reading_clause/query_graph.h → src/include/binder/query/query_graph.h
diff --git a/...include/binder/call/bound_in_query_call.h → ...uery/reading_clause/bound_in_query_call.h b/...include/binder/call/bound_in_query_call.h → ...uery/reading_clause/bound_in_query_call.h
diff --git a/src/include/binder/query/reading_clause/bound_match_clause.h b/src/include/binder/query/reading_clause/bound_match_clause.h
@@ -1,8 +1,8 @@
 #pragma once
 
 #include "binder/expression/expression.h"
+#include "binder/query/query_graph.h"
 #include "bound_reading_clause.h"
-#include "query_graph.h"
 
 namespace kuzu {
 namespace binder {

diff --git a/src/include/binder/query/updating_clause/bound_merge_clause.h b/src/include/binder/query/updating_clause/bound_merge_clause.h
@@ -1,6 +1,6 @@
 #pragma once
 
-#include "binder/query/reading_clause/query_graph.h"
+#include "binder/query/query_graph.h"
 #include "bound_create_info.h"
 #include "bound_set_info.h"
 #include "bound_updating_clause.h"

diff --git a/src/include/planner/join_order/cardinality_estimator.h b/src/include/planner/join_order/cardinality_estimator.h
@@ -1,6 +1,6 @@
 #pragma once
 
-#include "binder/query/reading_clause/query_graph.h"
+#include "binder/query/query_graph.h"
 #include "planner/logical_plan/logical_plan.h"
 #include "storage/store/nodes_statistics_and_deleted_ids.h"
 #include "storage/store/rels_statistics.h"

diff --git a/src/include/planner/query_planner.h b/src/include/planner/query_planner.h
@@ -1,8 +1,8 @@
 #pragma once
 
 #include "binder/bound_statement.h"
-#include "binder/call/bound_in_query_call.h"
 #include "binder/expression/existential_subquery_expression.h"
+#include "binder/query/reading_clause/bound_in_query_call.h"
 #include "join_order_enumerator.h"
 #include "planner/join_order/cardinality_estimator.h"
 #include "projection_planner.h"

diff --git a/src/include/planner/subplans_table.h b/src/include/planner/subplans_table.h
@@ -5,7 +5,7 @@
 #include <unordered_map>
 #include <unordered_set>
 
-#include "binder/query/reading_clause/query_graph.h"
+#include "binder/query/query_graph.h"
 #include "planner/logical_plan/logical_plan.h"
 
 using namespace kuzu::binder;

diff --git a/src/optimizer/filter_push_down_optimizer.cpp b/src/optimizer/filter_push_down_optimizer.cpp
@@ -1,8 +1,8 @@
 #include "optimizer/filter_push_down_optimizer.h"
 
-#include "binder/expression/expression_visitor.h"
 #include "binder/expression/literal_expression.h"
 #include "binder/expression/property_expression.h"
+#include "binder/expression_visitor.h"
 #include "planner/logical_plan/logical_operator/logical_dummy_scan.h"
 #include "planner/logical_plan/logical_operator/logical_filter.h"
 #include "planner/logical_plan/logical_operator/logical_scan_node.h"

diff --git a/src/optimizer/projection_push_down_optimizer.cpp b/src/optimizer/projection_push_down_optimizer.cpp
@@ -1,6 +1,6 @@
 #include "optimizer/projection_push_down_optimizer.h"
 
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 #include "planner/logical_plan/logical_operator/logical_accumulate.h"
 #include "planner/logical_plan/logical_operator/logical_create.h"
 #include "planner/logical_plan/logical_operator/logical_delete.h"

diff --git a/src/planner/join_order/append_extend.cpp b/src/planner/join_order/append_extend.cpp
@@ -1,4 +1,4 @@
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 #include "planner/join_order/cost_model.h"
 #include "planner/join_order_enumerator.h"
 #include "planner/logical_plan/logical_operator/logical_extend.h"

diff --git a/src/planner/join_order_enumerator.cpp b/src/planner/join_order_enumerator.cpp
@@ -1,6 +1,6 @@
 #include "planner/join_order_enumerator.h"
 
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 #include "planner/join_order/cost_model.h"
 #include "planner/logical_plan/logical_operator/logical_scan_node.h"
 #include "planner/query_planner.h"

diff --git a/src/planner/operator/schema.cpp b/src/planner/operator/schema.cpp
@@ -1,6 +1,6 @@
 #include "planner/logical_plan/logical_operator/schema.h"
 
-#include "binder/expression/expression_visitor.h"
+#include "binder/expression_visitor.h"
 #include "common/exception.h"
 
 using namespace kuzu::binder;

diff --git a/src/planner/planner.cpp b/src/planner/planner.cpp
@@ -1,7 +1,8 @@
 #include "planner/planner.h"
 
+#include "binder/bound_create_macro.h"
 #include "binder/bound_explain.h"
-#include "binder/call/bound_standalone_call.h"
+#include "binder/bound_standalone_call.h"
 #include "binder/copy/bound_copy_from.h"
 #include "binder/copy/bound_copy_to.h"
 #include "binder/ddl/bound_add_property.h"
@@ -12,7 +13,6 @@
 #include "binder/ddl/bound_rename_property.h"
 #include "binder/ddl/bound_rename_table.h"
 #include "binder/expression/variable_expression.h"
-#include "binder/macro/bound_create_macro.h"
 #include "planner/logical_plan/logical_operator/logical_add_property.h"
 #include "planner/logical_plan/logical_operator/logical_copy_from.h"
 #include "planner/logical_plan/logical_operator/logical_copy_to.h"

diff --git a/src/planner/projection_planner.cpp b/src/planner/projection_planner.cpp
@@ -1,7 +1,7 @@
 #include "planner/projection_planner.h"
 
-#include "binder/expression/expression_visitor.h"
 #include "binder/expression/function_expression.h"
+#include "binder/expression_visitor.h"
 #include "planner/logical_plan/logical_operator/flatten_resolver.h"
 #include "planner/logical_plan/logical_operator/logical_aggregate.h"
 #include "planner/logical_plan/logical_operator/logical_limit.h"

diff --git a/src/planner/query_planner.cpp b/src/planner/query_planner.cpp
@@ -1,7 +1,7 @@
 #include "planner/query_planner.h"
 
-#include "binder/expression/expression_visitor.h"
 #include "binder/expression/literal_expression.h"
+#include "binder/expression_visitor.h"
 #include "binder/query/bound_regular_query.h"
 #include "binder/visitor/property_collector.h"
 #include "common/join_type.h"