clean

kuzudb · Mar 16, 2023 · a8f4526 · a8f4526
1 parent e465558
commit a8f4526
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 435 deletions.
diff --git a/src/include/common/utils.h b/src/include/common/utils.h
@@ -10,7 +10,6 @@
 #include <vector>
 
 #include "common/constants.h"
-#include "common/types/types.h"
 #include "exception.h"
 #include "spdlog/fmt/fmt.h"
 

diff --git a/src/include/storage/buffer_manager/buffer_pool.h b/src/include/storage/buffer_manager/buffer_pool.h
diff --git a/src/storage/buffer_manager/bm_managed_file_handle.cpp b/src/storage/buffer_manager/bm_managed_file_handle.cpp
@@ -155,6 +155,7 @@ void BMFileHandle::clearWALPageVersionIfNecessary(common::page_idx_t pageIdx) {
     }
     createPageVersionGroupIfNecessary(pageIdx);
     setWALPageVersionNoLock(pageIdx, UINT32_MAX);
+    // TODO(Guodong): Why do we release lock here? Need to understand how the lock was acquired.
     releasePageLock(pageIdx);
 }
 

diff --git a/src/storage/buffer_manager/buffer_manager.cpp b/src/storage/buffer_manager/buffer_manager.cpp
@@ -257,7 +257,6 @@ void BufferManager::removePageFromFrame(
     fileHandle.acquirePageLock(pageIdx, LockMode::SPIN);
     auto pageState = fileHandle.getPageState(pageIdx);
     if (pageState && pageState->isCached()) {
-        assert(pageState->getPinCount() == 0);
         if (shouldFlush) {
             flushIfDirtyWithoutLock(fileHandle, pageIdx);
         }