-
Notifications
You must be signed in to change notification settings - Fork 94
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previously we used LD_PRELOAD to add ASAN to our build. This is at best imperfect, since the full benefits of ASAN can only be realized by adding compiler instrumentation. This does not run the python, nodejs, or java tests with ASAN. Though Python can be run with ASAN using LD_PRELOAD, it is super slow, and would need parallelized testing to be viable (which is not worth it IMO). Nodejs and Java just die spectacularly. Overall I think the APIs need ASAN much less.
- Loading branch information
Showing
3 changed files
with
6 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters