Skip to content

Commit

Permalink
[1100] Inconsistent parameter order in RelsStore
Browse files Browse the repository at this point in the history
  • Loading branch information
anuchak committed Jan 6, 2023
1 parent 9482d84 commit 8caa5a1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/storage/wal_replayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ void WALReplayer::replayWALRecord(WALRecord& walRecord) {
storageStructureID.columnFileID.relPropertyColumnID.relNodeTableAndDir;
Column* column =
storageManager->getRelsStore().getRelPropertyColumn(relNodeTableAndDir.dir,
relNodeTableAndDir.relTableID, relNodeTableAndDir.srcNodeTableID,
relNodeTableAndDir.srcNodeTableID, relNodeTableAndDir.relTableID,
storageStructureID.columnFileID.relPropertyColumnID.propertyID);
diskOverflowFile =
reinterpret_cast<PropertyColumnWithOverflow*>(column)->getDiskOverflowFile();
Expand Down Expand Up @@ -368,7 +368,7 @@ VersionedFileHandle* WALReplayer::getVersionedFileHandleIfWALVersionAndBMShouldB
storageStructureID.columnFileID.relPropertyColumnID.relNodeTableAndDir;
Column* column =
storageManager->getRelsStore().getRelPropertyColumn(relNodeTableAndDir.dir,
relNodeTableAndDir.relTableID, relNodeTableAndDir.srcNodeTableID,
relNodeTableAndDir.srcNodeTableID, relNodeTableAndDir.relTableID,
storageStructureID.columnFileID.relPropertyColumnID.propertyID);
return storageStructureID.isOverflow ?
reinterpret_cast<PropertyColumnWithOverflow*>(column)
Expand Down
2 changes: 1 addition & 1 deletion test/copy_csv/copy_csv_lists_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ TEST_F(TinySnbListTest, RelPropertyColumnWithList) {
catalog->getReadOnlyVersion()->getNodeTableIDFromName("person");
auto& property = catalog->getReadOnlyVersion()->getRelProperty(tableID, "places");
auto col = graph->getRelsStore().getRelPropertyColumn(
RelDirection::FWD, tableID, nodeTablesForAdjColumnAndProperties, property.propertyID);
RelDirection::FWD, nodeTablesForAdjColumnAndProperties, tableID, property.propertyID);
ASSERT_TRUE(CheckEquals({"wwAewsdndweusd", "wek"}, col->readValue(0)));
ASSERT_TRUE(CheckEquals({"anew", "jsdnwusklklklwewsd"}, col->readValue(1)));
ASSERT_TRUE(CheckEquals({"awndsnjwejwen", "isuhuwennjnuhuhuwewe"}, col->readValue(5)));
Expand Down

0 comments on commit 8caa5a1

Please sign in to comment.