Skip to content

Commit

Permalink
Fix on review
Browse files Browse the repository at this point in the history
  • Loading branch information
manh9203 committed Apr 25, 2024
1 parent 41a35c4 commit 8bcfd4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/processor/operator/persistent/reader/npy/npy_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,7 @@ static void bindColumns(const common::ReaderConfig& readerConfig,
static std::unique_ptr<function::TableFuncBindData> bindFunc(main::ClientContext* /*context*/,
function::TableFuncBindInput* input) {
auto scanInput = reinterpret_cast<function::ScanTableFuncBindInput*>(input);
if (!scanInput->config.options.empty()) {
throw BinderException{"Copy from Npy cannot have options."};
}
KU_ASSERT(scanInput->config.options.empty());
std::vector<std::string> detectedColumnNames;
std::vector<common::LogicalType> detectedColumnTypes;
bindColumns(scanInput->config, detectedColumnNames, detectedColumnTypes);
Expand Down
3 changes: 1 addition & 2 deletions test/test_files/copy/copy_node_parquet.test
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@
---- 1
546

-CASE CopyWithOptionsErrorTest

-LOG CopyWithOptionsErrorTest
-STATEMENT COPY tableOfTypes FROM "${KUZU_ROOT_DIRECTORY}/dataset/copy-test/node/parquet/types_50k*.parquet" (HEADER=true);
---- error
Binder exception: Copy from Parquet cannot have options.

0 comments on commit 8bcfd4c

Please sign in to comment.