ci: check clang-tidy on macOS

.github/workflows/ci-workflow.yml

@@ -309,6 +309,31 @@ jobs:
       - name: Benchmark
         run: python3 benchmark/benchmark_runner.py --dataset ldbc-sf100 --thread 10
 
+  macos-clang-tidy:
+    name: macos clang tidy & clangd diagnostics check
+    needs: [clang-formatting-check, include-guard-and-no-std-assert]
+    runs-on: self-hosted-mac-x64
+    env:
+      NUM_THREADS: 32
+      GEN: ninja
+
+    steps:
+      - uses: actions/checkout@v3
+
+      # For `napi.h` header.
+      - name: Ensure Node.js dependencies
+        run: npm install --include=dev
+        working-directory: tools/nodejs_api
+
+      - name: Check for clangd diagnostics
+        run: make clangd-diagnostics
+
+      - name: Run clang-tidy
+        run: make tidy
+
+      - name: Run clang-tidy analyzer
+        run: make tidy-analyzer
+
   macos-build-test:
     name: apple clang build & test
     needs: [clang-formatting-check, include-guard-and-no-std-assert, rustfmt-check]

scripts/get-clangd-diagnostics.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 import argparse
 import io
 import json

scripts/run-clang-format.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 """A wrapper script around clang-format, suitable for linting multiple files
 and to use for continuous integration.
 

src/include/processor/operator/aggregate/hash_aggregate.h

@@ -6,6 +6,7 @@
 namespace kuzu {
 namespace processor {
 
+// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor): This is a final class.
 class HashAggregateSharedState final : public BaseAggregateSharedState {
 
 public:

src/include/processor/operator/aggregate/simple_aggregate.h

@@ -6,6 +6,7 @@
 namespace kuzu {
 namespace processor {
 
+// NOLINTNEXTLINE(cppcoreguidelines-virtual-class-destructor): This is a final class.
 class SimpleAggregateSharedState final : public BaseAggregateSharedState {
 public:
     explicit SimpleAggregateSharedState(