Use cross-platform glob library to better support globbing on windows

src/common/CMakeLists.txt

@@ -21,6 +21,8 @@ add_library(kuzu_common
         utils.cpp
         string_utils.cpp)
 
+target_link_libraries(kuzu_common Glob)
+
 set(ALL_OBJECT_FILES
         ${ALL_OBJECT_FILES} $<TARGET_OBJECTS:kuzu_common>
         PARENT_SCOPE)

src/common/file_utils.cpp

@@ -2,6 +2,7 @@
 
 #include "common/exception.h"
 #include "common/string_utils.h"
+#include <glob/glob.hpp>
 
 namespace kuzu {
 namespace common {
@@ -118,12 +119,9 @@ void FileUtils::removeFileIfExists(const std::string& path) {
 
 std::vector<std::string> FileUtils::globFilePath(const std::string& path) {
     std::vector<std::string> result;
-    glob_t globResult;
-    glob(path.c_str(), GLOB_TILDE, nullptr, &globResult);
-    for (auto i = 0u; i < globResult.gl_pathc; ++i) {
-        result.emplace_back(globResult.gl_pathv[i]);
+    for (auto &resultPath: glob::glob(path)) {
+        result.emplace_back(resultPath.string());
     }
-    globfree(&globResult);
     return result;
 }
 

src/include/common/file_utils.h

@@ -1,7 +1,6 @@
 #pragma once
 
 #include <fcntl.h>
-#include <glob.h>
 #include <sys/stat.h>
 #include <unistd.h>
 

third_party/CMakeLists.txt

@@ -3,3 +3,4 @@ add_subdirectory(antlr4_cypher)
 add_subdirectory(utf8proc)
 add_subdirectory(pybind11)
 add_subdirectory(re2)
+add_subdirectory(glob)

third_party/glob/CMakeLists.txt

@@ -0,0 +1,3 @@
+add_library(Glob INTERFACE glob/glob.hpp)
+
+target_include_directories(Glob INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})