fix bugs for lpad rpad and shell

kuzudb · Nov 18, 2022 · 6361d9f · 6361d9f
1 parent 8926807
commit 6361d9f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/src/function/string/operations/include/base_lower_upper_operation.h b/src/function/string/operations/include/base_lower_upper_operation.h
@@ -36,6 +36,7 @@ struct BaseLowerUpperOperation {
     static uint32_t getResultLen(char* inputStr, uint32_t inputLen, bool isUpper);
     static void convertCase(char* result, uint32_t len, char* input, bool toUpper);
 };
+
 } // namespace operation
 } // namespace function
 } // namespace kuzu
diff --git a/src/function/string/operations/include/base_pad_operation.h b/src/function/string/operations/include/base_pad_operation.h
@@ -24,6 +24,9 @@ struct BasePadOperation {
         ku_string_t& result, ValueVector& resultValueVector,
         void (*padOperation)(
             ku_string_t& src, int64_t count, ku_string_t& characterToPad, string& paddedResult)) {
+        if(count < 0) {
+            count = 0;
+        }
         string paddedResult;
         padOperation(src, count, characterToPad, paddedResult);
         result.len = paddedResult.size();

diff --git a/test/test_files/tinySNB/function/string.test b/test/test_files/tinySNB/function/string.test
@@ -346,6 +346,13 @@ Huber
 âóâThe 😂😃🧘🏻‍♂️🌍🌦️🍞🚗 movie
 âóâóâóâóâóâóâóâóâóâóâRoma
 
+-NAME LpadNegativeCount
+-QUERY MATCH (m:movies) RETURN lpad(m.name, -1, ".")
+---- 3
+
+
+
+
 # TODO(Semih): Uncomment when enabling ad-hoc properties
 #-NAME LpadStructuredStrAndStructuredInt
 #-QUERY MATCH (p:person) RETURN lpad(p.fName, p.ID, "<")
@@ -390,6 +397,13 @@ Sóló cón tu párejââó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞
 The 😂😃🧘🏻‍♂️🌍🌦️🍞🚗 movieâó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞
 Romaâó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞🚗âó😂😃🍞
 
+-NAME RpadNegativeCount
+-QUERY MATCH (m:movies) RETURN rpad(m.name, -1, "âó😂😃🍞🚗")
+---- 3
+
+
+
+
 -NAME RpadStructuredStrAndStructuredInt
 -QUERY MATCH (p:person) RETURN rpad(p.fName, p.ID, "<")
 ---- 8

diff --git a/third_party/utf8proc/BUILD.bazel b/third_party/utf8proc/BUILD.bazel
@@ -8,7 +8,6 @@ cc_library(
     hdrs = glob([
         "include/*.h",
     ]),
-    visibility = ["//visibility:public"],
-    deps = [],
+    visibility = ["//visibility:public"]
 )
 
diff --git a/tools/shell/linenoise.cpp b/tools/shell/linenoise.cpp
@@ -820,7 +820,7 @@ void linenoiseEditMoveRight(struct linenoiseState* l) {
 
 /* Checks to see if character defines a separation between words */
 bool isWordSeparator(char c) {
-    return (!isalpha(c) && !isdigit(c));
+    return (c == 0x20);
 }
 
 /* Move cursor one word to the left */