Fix create node bug

src/binder/bind/bind_updating_clause.cpp

@@ -65,12 +65,23 @@ std::unique_ptr<BoundCreateNode> Binder::bindCreateNode(
     auto primaryKey = nodeTableSchema->getPrimaryKey();
     std::shared_ptr<Expression> primaryKeyExpression;
     std::vector<expression_pair> setItems;
+    for (auto& property : catalog.getReadOnlyVersion()->getNodeProperties(nodeTableID)) {
+        if (collection.hasKeyVal(node, property.name)) {
+            setItems.emplace_back(collection.getKeyVal(node, property.name));
+        } else {
+            auto propertyExpression =
+                expressionBinder.bindNodePropertyExpression(*node, property.name);
+            auto nullExpression = expressionBinder.createNullLiteralExpression();
+            nullExpression = ExpressionBinder::implicitCastIfNecessary(
+                nullExpression, propertyExpression->dataType);
+            setItems.emplace_back(std::move(propertyExpression), std::move(nullExpression));
+        }
+    }
     for (auto& [key, val] : collection.getKeyVals(node)) {
         auto propertyExpression = static_pointer_cast<PropertyExpression>(key);
         if (propertyExpression->getPropertyID(nodeTableID) == primaryKey.propertyID) {
             primaryKeyExpression = val;
         }
-        setItems.emplace_back(key, val);
     }
     if (nodeTableSchema->getPrimaryKey().dataType.getLogicalTypeID() != LogicalTypeID::SERIAL &&
         primaryKeyExpression == nullptr) {

src/catalog/catalog.cpp

@@ -249,10 +249,6 @@ const Property& CatalogContent::getRelProperty(
     throw CatalogException("Cannot find rel property " + propertyName + ".");
 }
 
-std::vector<Property> CatalogContent::getAllNodeProperties(table_id_t tableID) const {
-    return nodeTableSchemas.at(tableID)->getAllNodeProperties();
-}
-
 void CatalogContent::dropTableSchema(table_id_t tableID) {
     auto tableSchema = getTableSchema(tableID);
     if (tableSchema->isNodeTable) {

src/include/catalog/catalog.h

@@ -102,9 +102,11 @@ class CatalogContent {
     const Property& getRelProperty(
         common::table_id_t tableID, const std::string& propertyName) const;
 
-    std::vector<Property> getAllNodeProperties(common::table_id_t tableID) const;
+    inline const std::vector<Property>& getNodeProperties(common::table_id_t tableID) const {
+        return nodeTableSchemas.at(tableID)->getProperties();
+    }
     inline const std::vector<Property>& getRelProperties(common::table_id_t tableID) const {
-        return relTableSchemas.at(tableID)->properties;
+        return relTableSchemas.at(tableID)->getProperties();
     }
     inline std::vector<common::table_id_t> getNodeTableIDs() const {
         std::vector<common::table_id_t> nodeTableIDs;

src/include/catalog/catalog_structs.h

@@ -63,7 +63,7 @@ struct TableSchema {
         return std::any_of(properties.begin(), properties.end(),
             [&propertyName](const Property& property) { return property.name == propertyName; });
     }
-
+    inline const std::vector<Property>& getProperties() const { return properties; }
     inline void addProperty(std::string propertyName, common::LogicalType dataType) {
         properties.emplace_back(
             std::move(propertyName), std::move(dataType), increaseNextPropertyID(), tableID);
@@ -102,8 +102,6 @@ struct NodeTableSchema : TableSchema {
 
     inline Property getPrimaryKey() const { return properties[primaryKeyPropertyID]; }
 
-    inline std::vector<Property> getAllNodeProperties() const { return properties; }
-
     // TODO(Semih): When we support updating the schemas, we need to update this or, we need
     // a more robust mechanism to keep track of which property is the primary key (e.g., store this
     // information with the property). This is an idx, not an ID, so as the columns/properties of

src/include/storage/storage_structure/column.h

@@ -39,7 +39,7 @@ class Column : public BaseColumnOrList {
     void write(common::ValueVector* nodeIDVector, common::ValueVector* vectorToWriteFrom);
 
     bool isNull(common::offset_t nodeOffset, transaction::Transaction* transaction);
-    void setNull(common::offset_t nodeOffset);
+    virtual void setNull(common::offset_t nodeOffset);
 
     inline NullColumn* getNullColumn() { return nullColumn.get(); }
 
@@ -175,6 +175,11 @@ class StructPropertyColumn : public Column {
     void read(transaction::Transaction* transaction, common::ValueVector* nodeIDVector,
         common::ValueVector* resultVector) final;
 
+    void setNull(common::offset_t nodeOffset) final;
+
+    void write(common::offset_t nodeOffset, common::ValueVector* vectorToWriteFrom,
+        uint32_t posInVectorToWriteFrom) override;
+
 private:
     std::vector<std::unique_ptr<Column>> structFieldColumns;
 };

src/main/connection.cpp

@@ -245,7 +245,7 @@ std::string Connection::getNodePropertyNames(const std::string& tableName) {
     auto tableID = catalog->getReadOnlyVersion()->getTableID(tableName);
     auto primaryKeyPropertyID =
         catalog->getReadOnlyVersion()->getNodeTableSchema(tableID)->getPrimaryKey().propertyID;
-    for (auto& property : catalog->getReadOnlyVersion()->getAllNodeProperties(tableID)) {
+    for (auto& property : catalog->getReadOnlyVersion()->getNodeProperties(tableID)) {
         result +=
             "\t" + property.name + " " + LogicalTypeUtils::dataTypeToString(property.dataType);
         result += property.propertyID == primaryKeyPropertyID ? "(PRIMARY KEY)\n" : "\n";

src/processor/result/factorized_table.cpp

@@ -351,6 +351,7 @@ void FactorizedTable::setOverflowColNull(
 // TODO(Guodong): change this function to not use dataChunkPos in ColumnSchema.
 uint64_t FactorizedTable::computeNumTuplesToAppend(
     const std::vector<ValueVector*>& vectorsToAppend) const {
+    assert(!vectorsToAppend.empty());
     auto unflatDataChunkPos = -1ul;
     auto numTuplesToAppend = 1ul;
     for (auto i = 0u; i < vectorsToAppend.size(); i++) {

src/storage/storage_structure/column.cpp

@@ -86,6 +86,9 @@ bool Column::isNull(common::offset_t nodeOffset, transaction::Transaction* trans
 
 void Column::setNull(common::offset_t nodeOffset) {
     nullColumn->setValue(nodeOffset);
+    auto walPageInfo = createWALVersionOfPageIfNecessaryForElement(nodeOffset, numElementsPerPage);
+    bufferManager->unpin(*wal->fileHandle, walPageInfo.pageIdxInWAL);
+    fileHandle->releaseWALPageIdxLock(walPageInfo.originalPageIdx);
 }
 
 Value Column::readValueForTestingOnly(offset_t offset) {
@@ -325,6 +328,23 @@ void StructPropertyColumn::read(Transaction* transaction, common::ValueVector* n
     }
 }
 
+void StructPropertyColumn::setNull(common::offset_t nodeOffset) {
+    nullColumn->setValue(nodeOffset);
+    // TODO(Ziyi): we currently only support create a node/rel with null struct property because
+    // we don't have a mechanism to log the sub columns of a struct column.
+}
+
+void StructPropertyColumn::write(common::offset_t nodeOffset,
+    common::ValueVector* vectorToWriteFrom, uint32_t posInVectorToWriteFrom) {
+    bool isNull = vectorToWriteFrom->isNull(posInVectorToWriteFrom);
+    if (nullColumn) {
+        nullColumn->write(nodeOffset, vectorToWriteFrom, posInVectorToWriteFrom);
+    }
+    if (!isNull) {
+        throw common::RuntimeException{"Can only update a null value to struct column."};
+    }
+}
+
 void InternalIDColumn::readInternalIDsFromPage(transaction::Transaction* transaction,
     uint8_t* frame, PageElementCursor& pageCursor, common::ValueVector* resultVector,
     uint32_t posInVector, uint32_t numValuesToRead, DiskOverflowFile* diskOverflowFile) {

src/storage/store/node_table.cpp

@@ -16,7 +16,7 @@ NodeTable::NodeTable(NodesStatisticsAndDeletedIDs* nodesStatisticsAndDeletedIDs,
 std::unordered_map<common::property_id_t, std::unique_ptr<Column>> NodeTable::initializeColumns(
     WAL* wal, kuzu::storage::BufferManager* bm, NodeTableSchema* nodeTableSchema) {
     std::unordered_map<common::property_id_t, std::unique_ptr<Column>> propertyColumns;
-    for (auto& property : nodeTableSchema->getAllNodeProperties()) {
+    for (auto& property : nodeTableSchema->getProperties()) {
         propertyColumns[property.propertyID] = ColumnFactory::getColumn(
             StorageUtils::getNodePropertyColumnStructureIDAndFName(wal->getDirectory(), property),
             property.dataType, bm, wal);

test/test_files/tck/match/match1.test

@@ -10,9 +10,7 @@
 Binder exception: No node table exists in database.
 
 # Matching all nodes
-# TODO(Guodong/Ziyi): Fixme
 -CASE Scenario2
--SKIP
 -STATEMENT CREATE NODE TABLE A(ID SERIAL, name STRING, PRIMARY KEY(ID));
 ---- ok
 -STATEMENT CREATE NODE TABLE B(ID SERIAL, name STRING, PRIMARY KEY(ID));
@@ -21,13 +19,11 @@ Binder exception: No node table exists in database.
 ---- ok
 -STATEMENT MATCH (n) RETURN n;
 ---- 2
-1
-2
+{_ID: 0:0, _LABEL: A, ID: 0}
+{_ID: 1:0, _LABEL: B, ID: 0, name: b}
 
 # Matching nodes using multiple labels
-# TODO(Guodong/Ziyi): Fixme
 -CASE Scenario3
--SKIP
 -STATEMENT CREATE NODE TABLE A(ID SERIAL, PRIMARY KEY(ID));
 ---- ok
 -STATEMENT CREATE NODE TABLE B(ID SERIAL, PRIMARY KEY(ID));
@@ -37,8 +33,9 @@ Binder exception: No node table exists in database.
 -STATEMENT CREATE (:A), (:B), (:C);
 ---- ok
 -STATEMENT MATCH (a:A:B) RETURN a;
----- 1
-1
+---- 2
+{_ID: 0:0, _LABEL: A, ID: 0}
+{_ID: 1:0, _LABEL: B, ID: 0}
 
 # Simple node inlnie property predicate
 -CASE Scenario4