Fix distinct hash table performance bug (#3350)

kuzudb · Apr 23, 2024 · 2f5c63d · 2f5c63d
1 parent 41a2468
commit 2f5c63d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/processor/operator/aggregate/aggregate_hash_table.cpp b/src/processor/operator/aggregate/aggregate_hash_table.cpp
@@ -49,7 +49,7 @@ bool AggregateHashTable::isAggregateValueDistinctForGroupByKeys(
     }
     distinctKeyVectors[groupByFlatKeyVectors.size()] = aggregateVector;
     computeVectorHashes(distinctKeyVectors, std::vector<ValueVector*>() /* unFlatKeyVectors */);
-    hash_t hash = hashVector->getValue<hash_t>(hashVector->state->selVector->selectedPositions[0]);
+    auto hash = hashVector->getValue<hash_t>(hashVector->state->selVector->selectedPositions[0]);
     auto distinctHTEntry = findEntryInDistinctHT(distinctKeyVectors, hash);
     if (distinctHTEntry == nullptr) {
         resizeHashTableIfNecessary(1);
@@ -378,6 +378,7 @@ uint8_t* AggregateHashTable::createEntryInDistinctHT(
         factorizedTable->updateFlatCell(entry, i, groupByHashKeyVectors[i],
             groupByHashKeyVectors[i]->state->selVector->selectedPositions[0]);
     }
+    factorizedTable->updateFlatCellNoNull(entry, hashColIdxInFT, &hash);
     fillEntryWithInitialNullAggregateState(entry);
     fillHashSlot(hash, entry);
     return entry;