Merge pull request #2121 from kuzudb/windows-binary-mode

reader/csv: Use binary mode on Windows
kuzudb · Sep 30, 2023 · 23e43b3 · 23e43b3
2 parents bc74559 + 45a2362
commit 23e43b3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/processor/operator/persistent/reader/csv/base_csv_reader.cpp b/src/processor/operator/persistent/reader/csv/base_csv_reader.cpp
@@ -24,7 +24,11 @@ BaseCSVReader::BaseCSVReader(const std::string& filePath, const common::ReaderCo
       buffer(nullptr), bufferSize(0), position(0), rowEmpty(false), mode(ParserMode::INVALID),
       rowToAdd(0) {
     // TODO(Ziyi): should we wrap this fd using kuzu file handler?
-    fd = open(filePath.c_str(), O_RDONLY);
+    fd = open(filePath.c_str(), O_RDONLY
+#ifdef _WIN32
+                                    | _O_BINARY
+#endif
+    );
     if (fd == -1) {
         throw CopyException(
             StringUtils::string_format("Could not open file {}: {}", filePath, strerror(errno)));