clean

kuzudb · Apr 18, 2023 · 196d240 · 196d240
1 parent 7062379
commit 196d240
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 7 deletions.
diff --git a/src/binder/bind/bind_graph_pattern.cpp b/src/binder/bind/bind_graph_pattern.cpp
@@ -138,7 +138,6 @@ void Binder::bindQueryRel(const RelPattern& relPattern,
     for (auto tableID : tableIDs) {
         relTableSchemas.push_back(catalog.getReadOnlyVersion()->getRelTableSchema(tableID));
     }
-    // TODO(Xiyang): revisit this
     // we don't support reading property for VARIABLE_LENGTH or SHORTEST rel.
     if (queryRel->getRelType() == common::QueryRelType::ONE_HOP) {
         for (auto& [propertyName, propertySchemas] :

diff --git a/src/include/planner/join_order_enumerator.h b/src/include/planner/join_order_enumerator.h
@@ -82,8 +82,6 @@ class JoinOrderEnumerator {
 
     void appendScanNodeID(std::shared_ptr<NodeExpression>& node, LogicalPlan& plan);
 
-    //    bool needExtendToNewGroup(
-    //        RelExpression& rel, NodeExpression& boundNode, common::RelDirection direction);
     void appendRegularExtend(std::shared_ptr<NodeExpression> boundNode,
         std::shared_ptr<NodeExpression> nbrNode, std::shared_ptr<RelExpression> rel,
         common::RelDirection direction, const binder::expression_vector& properties,

diff --git a/src/include/planner/logical_plan/logical_operator/base_logical_extend.h b/src/include/planner/logical_plan/logical_operator/base_logical_extend.h
@@ -32,4 +32,4 @@ class BaseLogicalExtend : public LogicalOperator {
 };
 
 } // namespace planner
-} // namespace kuzu
+} // namespace kuzu
diff --git a/src/include/planner/logical_plan/logical_operator/logical_recursive_extend.h b/src/include/planner/logical_plan/logical_operator/logical_recursive_extend.h
@@ -56,4 +56,4 @@ class LogicalShortestPathExtend : public LogicalRecursiveExtend {
 };
 
 } // namespace planner
-} // namespace kuzu
+} // namespace kuzu
diff --git a/src/planner/operator/base_logical_extend.cpp b/src/planner/operator/base_logical_extend.cpp
@@ -35,4 +35,4 @@ std::string BaseLogicalExtend::getExpressionsForPrinting() const {
 }
 
 } // namespace planner
-} // namespace kuzu
+} // namespace kuzu
diff --git a/src/planner/operator/logical_extend.cpp b/src/planner/operator/logical_extend.cpp
@@ -7,7 +7,7 @@ namespace planner {
 
 f_group_pos_set LogicalExtend::getGroupsPosToFlatten() {
     f_group_pos_set result;
-    if (hasAtMostOneNbr) {
+    if (hasAtMostOneNbr) { // Column extend. No need to flatten input bound node.
         return result;
     }
     auto inSchema = children[0]->getSchema();