Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): deprecate option tsConfig in favor of tsconfig #1997

Merged
merged 2 commits into from
Oct 2, 2020
Merged

refactor(config): deprecate option tsConfig in favor of tsconfig #1997

merged 2 commits into from
Oct 2, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 1, 2020

Summary

To avoid confusion, we should use tsconfig instead of tsConfig. This PR sets a warning log to instruct users to use tsconfig, as well as changing internal codes to use tsconfig.

The option tsConfig will be removed in v27

Test plan

Added unit test, green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Oct 1, 2020

Pull Request Test Coverage Report for Build 6031

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.241%

Totals Coverage Status
Change from base Build 6030: 0.01%
Covered Lines: 1135
Relevant Lines: 1169

💛 - Coveralls

@ahnpnl ahnpnl merged commit 8fec681 into kulshekhar:master Oct 2, 2020
@ahnpnl ahnpnl deleted the deprecate-tsConfig branch October 2, 2020 08:14
PhilippeMorier added a commit to PhilippeMorier/talus that referenced this pull request Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants