Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add the API server module #688

Merged
merged 12 commits into from
Mar 9, 2023
Merged

Conversation

barnettZQG
Copy link
Collaborator

@barnettZQG barnettZQG commented Mar 8, 2023

Description of your changes

Refer to kubevela/kubevela#5487

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
.eslintrc.js Fixed Show fixed Hide fixed
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@643166b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage        ?   60.14%           
=======================================
  Files           ?       94           
  Lines           ?    17595           
  Branches        ?        0           
=======================================
  Hits            ?    10583           
  Misses          ?     5701           
  Partials        ?     1311           
Flag Coverage Δ
apiserver-unittests 32.10% <0.00%> (?)
server-e2e-tests 49.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG marked this pull request as ready for review March 8, 2023 09:49
@barnettZQG barnettZQG added this to the 1.8 milestone Mar 8, 2023
runtimeCluster: false

system:
vela: ">=v1.6.0-alpha.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vela: ">=v1.6.0-alpha.6"
vela: ">=v1.6.0"

@barnettZQG barnettZQG merged commit 2e3bd62 into kubevela:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants