Fix virt-v2v disk name generation

[bkhizgiy]

Currently, the function generating the disk names didn't work as expected, and instead of matching the disk number with the corresponding letter, it caused the letters to be attached from the previous disk. This resulted in only the first disk being properly copied due to incorrect linking. With these changes, the disk name generation works as expected.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.48%. Comparing base (b679a00) to head (a79f099).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   17.59%   17.48%   -0.12%     
==========================================
  Files          94       95       +1     
  Lines       16853    17006     +153     
==========================================
+ Hits         2965     2973       +8     
- Misses      13621    13765     +144     
- Partials      267      268       +1     

Flag	Coverage Δ
unittests	17.48% <100.00%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ahadas]

I've made changes in the description of the PR, please update the commit (which is currently empty) accordingly
and also please add unit tests, there's a concrete case we can take from https://issues.redhat.com/browse/MTV-1098

[germanovm]

Won't this break at the 27th disk now by both the 1st and 27th disk being named sda instead of sdaa for the 27th?

[bkhizgiy]

@germanovm ahh yes, it will, we need to add the cycle back here like we had in the original code (but without the bug:) )

[ahadas]

@germanovm ahh yes, it will, we need to add the cycle back here like we had in the original code (but without the bug:) )

another case to cover in unit tests ;)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud