openstack: add simple test for the openstack-populator #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
openstack-test
branch
2 times, most recently
from
b7e57be
to
2ab9534
Compare
ahadas
reviewed
Dec 4, 2023
bennyz
force-pushed
the
openstack-test
branch
from
2ab9534
to
6653745
Compare
ahadas
reviewed
Dec 4, 2023
bennyz
force-pushed
the
openstack-test
branch
from
6653745
to
f6c52f5
Compare
@bennyz so what about that tiny part? |
Use envFrom to pass secrets to the populator controller. This simplifies the code, and makes the openstack test introduced in the patch easier to implement. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
It uses a fake openstack server, but a real file is created Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
openstack-test
branch
4 times, most recently
from
7a96fc8
to
b7dbf0e
Compare
liranr23
reviewed
Dec 19, 2023
bennyz
force-pushed
the
openstack-test
branch
from
b7dbf0e
to
6e86255
Compare
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
openstack-test
branch
from
6e86255
to
c77f297
Compare
|
ahadas
approved these changes
Dec 24, 2023
yeah, it's a cleaner way to get data from a secret in a pod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envFrominstead of a file to pass the secret.This will eventually go into the CDI controller PR, but is also useful here for now