Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1497 | Pass all gateways to the virt-v2v #1074

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 25, 2024

Issue:
We are not passing the gateway to the virt-v2v when there are multiple interfaces.

Fix:
Remove the limitation to have just one gateway and pass everything to the virt-v2v.
The MTV should not touch the configuration the VM should be the same after migration as it was before.

Test log:

exec: /usr/bin/virt-v2v -v -x -o kubevirt -os /var/tmp/v2v --root first -i libvirt -ic vpx://administrator%40vsphere.local@10.73.213.102/data/host/10.73.212.38?no_verify=1 -ip /etc/secret/secretKey --mac 00:50:56:92:ee:06:ip:10.73.100.100,10.73.100.10,24,10.73.100.1 --mac 00:50:56:92:25:f0:ip:192.168.24.50,192.168.24.1,24,192.168.24.10 -it vddk -io vddk-libdir=/opt/vmware-vix-disklib-distrib -io vddk-thumbprint=86:25:2F:5E:74:5C:43:D9:28:62:31:E0:1F:BB:1F:FD:AC:18:A5:93 -- mtv-esx7-win2022-2nics-2disks

This contains all IPAM configuraiton needed:

--mac 00:50:56:92:ee:06:ip:10.73.100.100,10.73.100.10,24,10.73.100.1
--mac 00:50:56:92:25:f0:ip:192.168.24.50,192.168.24.1,24,192.168.24.10

Signed-off-by: Martin Necas <mnecas@redhat.com>
@mnecas mnecas requested a review from yaacov as a code owner September 25, 2024 14:30
@mnecas mnecas removed the request for review from yaacov September 25, 2024 14:34
@mnecas
Copy link
Member Author

mnecas commented Sep 25, 2024

original:
image

after migration: image

Signed-off-by: Martin Necas <mnecas@redhat.com>
Copy link

sonarcloud bot commented Sep 25, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.27%. Comparing base (10d56ef) to head (5ef1246).

Files with missing lines Patch % Lines
pkg/controller/plan/adapter/vsphere/builder.go 71.42% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   16.28%   16.27%   -0.02%     
==========================================
  Files         112      112              
  Lines       19788    19785       -3     
==========================================
- Hits         3223     3220       -3     
  Misses      16280    16280              
  Partials      285      285              
Flag Coverage Δ
unittests 16.27% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit dd8e6a6 into kubev2v:main Sep 25, 2024
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants