Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better counting of migrated vms #575

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Better counting of migrated vms #575

merged 1 commit into from
Jul 18, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 18, 2023

Issue:
we currently only count vms by checking the conditions, but this will miss running vms

Fix:

  • check also vm phase and it's conditions, together we get better result
  • count also canceled migrations

@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 18, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 18, 2023
@yaacov
Better counting of migrated vms
fa648de 
Signed-off-by: yaacov <yzamir@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit 986fdba into kubev2v:main Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@yaacov