coredns: update notes in administer-cluster/coredns.md #8697

neolit123 · 2018-05-23T12:18:00Z

CoreDNS is installed by default in 1.11.
Add notes on how to install kube-dns instead.

Updates kubernetes/kubeadm#843

@kubernetes/sig-cluster-lifecycle-pr-reviews

k8sio-netlify-preview-bot · 2018-05-23T12:21:33Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 5db209a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b0743463672df0e0e52a10a

Bradamant3 · 2018-05-23T12:23:33Z

@neolit123 I see that this is a WIP, but if you could make sure to break that list of file changes into a couple of smaller PRs, they'll be easier to review. Thank you!

neolit123 · 2018-05-23T12:49:26Z

@Bradamant3

I see that this is a WIP, but if you could make sure to break that list of file changes into a couple of smaller PRs, they'll be easier to review. Thank you!

in that case this one is no longer WIP.
we should probably wait on approval from both SIG-Clusterlifecycle and SIG-Docs on these.

Bradamant3

Copyedits inline.

Bradamant3 · 2018-05-23T12:53:38Z

content/en/docs/tasks/administer-cluster/coredns.md

@@ -9,8 +9,7 @@ content_template: templates/task
 {{< feature-state state="beta" >}}


If the feature is moving to GA, we should remove this line.

Bradamant3 · 2018-05-23T12:54:21Z

content/en/docs/tasks/administer-cluster/coredns.md


+In Kubernetes 1.11, [CoreDNS](https://coredns.io) has graduated to General Availability (GA)
+and is installed by default. In case you want to install kube-dns instead, set the `CoreDNS` feature gate


s/In case you want to/To

Bradamant3 · 2018-05-23T12:54:51Z

content/en/docs/tasks/administer-cluster/coredns.md

 ## Upgrading an Existing Cluster with kubeadm

-In Kubernetes 1.10, you can also move to CoreDNS when you use `kubeadm` to upgrade
+Since Kubernetes 1.10, you can also move to CoreDNS when you use `kubeadm` to upgrade


s/Since Kubernetes 1.10/In Kubernetes version 1.10 and later

Bradamant3 · 2018-05-23T12:55:48Z

Thanks for the smaller PR!

neolit123 · 2018-05-23T12:58:55Z

updated. 👍

Thanks for the smaller PR!

this will complicate things for SIG-C.L. but we will try to handle it with the task list here:
kubernetes/kubeadm#843

Bradamant3 · 2018-05-23T13:03:12Z

/approve for docs review

waiting on lgtm from sig-cluster-lifecycle or another tech reviewer for merge
@neolit123 if you want to split the rest of your list into, say, 2 PRs, that would still help sig-docs, and make things easier for sig-cluster-lifecycle

Bradamant3 · 2018-05-23T13:29:16Z

/assign

johnbelamaric

It's not clear to me if it will automatically upgrade you to CoreDNS, or it will only do it on new installs.

Also, this note needs to be revised. @rajansandeep can you clarify the behavior here?

rajansandeep · 2018-05-23T19:04:16Z

@johnbelamaric CoreDNS will be installed by default during the kubeadm upgrade regardless of whether the previous DNS is kube-dns or CoreDNS.
(Unless someone sets the feature-gate flag for CoreDNS to false during upgrade.)

johnbelamaric · 2018-05-23T19:06:18Z

Ok, and if they are running CoreDNS and they upgrade, will it overwrite their Corefile and upgrade their manifest to the new image? If I recall correctly, this is the normal behavior with kube-dns today. If so, then we still need to document it clearly (but get rid of that GA note).

Bradamant3 · 2018-05-23T19:09:19Z

content/en/docs/tasks/administer-cluster/coredns.md

@@ -6,11 +6,8 @@ min-kubernetes-server-version: v1.9
 content_template: templates/task


Is the min-kubernetes-server-version still correct for these updates?

yes, the minimum version in this case is 1.9 when CoreDNS was introduced as alpha:
we are removing the following text from the file - In Kubernetes 1.9, [CoreDNS](https://coredns.io) is available as an alpha feature

rajansandeep · 2018-05-23T19:32:40Z

Any upgrade from CoreDNS to CoreDNS retains the previous Corefile set by the user.
The image is updated to the latest available to the specific release of K8s.

neolit123 · 2018-05-24T12:49:28Z

i will take @rajansandeep 's word for it and update the note about overwriting the user file in case of CoreDNS->CoreDNS upgrades.

neolit123 · 2018-05-24T13:10:50Z

@rajansandeep can you point me towards the modification in the source code that does this:

Any upgrade from CoreDNS to CoreDNS retains the previous Corefile set by the user.
The image is updated to the latest available to the specific release of K8s.

i cannot find it. i don't think we retain, but rather still overwrite the Corefile.

i was also told this:
kubernetes/kubernetes#63509 (comment)

when asking if the CoreDNS->CoreDNS part needs changes.

if i'm correct, i suggest the following text change:

This process will be modified for the GA release of this feature, such that an existing
Corefile will not be overwritten.

This process will be modified after GA release of this feature, such that an existing
Corefile will not be overwritten.

for -> after.

rajansandeep · 2018-05-24T13:14:58Z

@neolit123
This PR kubernetes/kubernetes#63400 ensures that the Corefile will be retained after upgrade.

neolit123 · 2018-05-24T13:16:59Z

@rajansandeep

This PR kubernetes/kubernetes#63400 ensures that the Corefile will be retained after upgrade.

...and i even reviewed it and forgot...wow.
ok, updating the notes.

neolit123 · 2018-05-24T13:39:22Z

@Bradamant3 @johnbelamaric
updated!

rajansandeep · 2018-05-24T14:06:53Z

content/en/docs/tasks/administer-cluster/coredns.md

 ## Upgrading an Existing Cluster with kubeadm

-In Kubernetes 1.10, you can also move to CoreDNS when you use `kubeadm` to upgrade
+In Kubernetes version 1.10 and later, you can also move to CoreDNS when you use `kubeadm` to upgrade
 a cluster that is using `kube-dns`. In this case, `kubeadm` will generate the CoreDNS configuration


Can you add a line to clarify that we need to set the CoreDNS feature-gates to true
kubeadm upgrade apply v1.11.0 --feature-gates=CoreDNS=true when moving from kube-dns to CoreDNS during an upgrade.

Is this done?

neolit123 · 2018-05-24T15:18:10Z

updated.

CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS.

mdlinville · 2018-05-24T22:59:55Z

I rebased this and it looks fine from a docs POV, but looks like there is some feedback that needs to be addressed and we need an LGTM from the SIG.

/approve

k8s-ci-robot · 2018-05-24T23:00:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3,mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

neolit123 · 2018-05-24T23:43:21Z

and we need an LGTM from the SIG.

the SIG folks haven't been active at website much, giving their +1...
i will ping them again tomorrow.

johnbelamaric · 2018-05-25T13:38:21Z

/lgtm

johnbelamaric · 2018-05-25T13:42:37Z

Oh, I see you wanted @kubernetes/sig-cluster-lifecycle-pr-reviews approval. Sorry about that! Please let me know if any updates are needed.

CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS.

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot requested review from johnbelamaric and zhangxiaoyu-zidif May 23, 2018 12:18

Bradamant3 added this to the 1.11 milestone May 23, 2018

neolit123 changed the title ~~[WIP] aggregate PR for the CoreDNS changes in 1.11~~ coredns: update notes in administer-cluster/coredns.md May 23, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2018

neolit123 mentioned this pull request May 23, 2018

document "CoreDNS by default in v1.11" kubernetes/kubeadm#843

Closed

11 tasks

Bradamant3 suggested changes May 23, 2018

View reviewed changes

neolit123 force-pushed the coredns branch from f1dae1b to 744dfd3 Compare May 23, 2018 12:57

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2018

Bradamant3 approved these changes May 23, 2018

View reviewed changes

k8s-ci-robot assigned Bradamant3 May 23, 2018

johnbelamaric suggested changes May 23, 2018

View reviewed changes

Bradamant3 reviewed May 23, 2018

View reviewed changes

neolit123 force-pushed the coredns branch from 744dfd3 to 0e069f0 Compare May 24, 2018 13:38

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2018

rajansandeep reviewed May 24, 2018

View reviewed changes

neolit123 force-pushed the coredns branch from 0e069f0 to 36eb095 Compare May 24, 2018 15:16

mdlinville force-pushed the release-1.11 branch from 5647835 to 8594900 Compare May 24, 2018 20:43

coredns: update notes in administer-cluster/coredns.md

5db209a

CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS.

mdlinville force-pushed the coredns branch from 36eb095 to 5db209a Compare May 24, 2018 22:57

mdlinville mentioned this pull request May 24, 2018

kubeadm: update info about CoreDNS in kubeadm-init.md #8728

Merged

k8s-ci-robot assigned johnbelamaric May 25, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2018

johnbelamaric approved these changes May 25, 2018

View reviewed changes

k8s-ci-robot merged commit 3a31498 into kubernetes:release-1.11 May 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

coredns: update notes in administer-cluster/coredns.md #8697

coredns: update notes in administer-cluster/coredns.md #8697

neolit123 commented May 23, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 23, 2018 •

edited

Loading

Bradamant3 commented May 23, 2018

neolit123 commented May 23, 2018

Bradamant3 left a comment

Bradamant3 May 23, 2018

Bradamant3 May 23, 2018

Bradamant3 May 23, 2018

Bradamant3 commented May 23, 2018

neolit123 commented May 23, 2018

Bradamant3 commented May 23, 2018 •

edited

Loading

Bradamant3 commented May 23, 2018

johnbelamaric left a comment

rajansandeep commented May 23, 2018

johnbelamaric commented May 23, 2018 via email

Bradamant3 May 23, 2018

neolit123 May 24, 2018

rajansandeep commented May 23, 2018

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

rajansandeep commented May 24, 2018

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

rajansandeep May 24, 2018

neolit123 May 24, 2018

mdlinville May 24, 2018

neolit123 May 24, 2018

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

k8s-ci-robot commented May 24, 2018

neolit123 commented May 24, 2018

johnbelamaric commented May 25, 2018

johnbelamaric commented May 25, 2018

		@@ -9,8 +9,7 @@ content_template: templates/task
		{{< feature-state state="beta" >}}


		In Kubernetes 1.11, [CoreDNS](https://coredns.io) has graduated to General Availability (GA)
		and is installed by default. In case you want to install kube-dns instead, set the `CoreDNS` feature gate

		@@ -6,11 +6,8 @@ min-kubernetes-server-version: v1.9
		content_template: templates/task

coredns: update notes in administer-cluster/coredns.md #8697

coredns: update notes in administer-cluster/coredns.md #8697

Conversation

neolit123 commented May 23, 2018 • edited Loading

k8sio-netlify-preview-bot commented May 23, 2018 • edited Loading

Bradamant3 commented May 23, 2018

neolit123 commented May 23, 2018

Bradamant3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bradamant3 commented May 23, 2018

neolit123 commented May 23, 2018

Bradamant3 commented May 23, 2018 • edited Loading

Bradamant3 commented May 23, 2018

johnbelamaric left a comment

Choose a reason for hiding this comment

rajansandeep commented May 23, 2018

johnbelamaric commented May 23, 2018 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rajansandeep commented May 23, 2018

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

rajansandeep commented May 24, 2018

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

k8s-ci-robot commented May 24, 2018

neolit123 commented May 24, 2018

johnbelamaric commented May 25, 2018

johnbelamaric commented May 25, 2018

neolit123 commented May 23, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 23, 2018 •

edited

Loading

Bradamant3 commented May 23, 2018 •

edited

Loading