Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link for kubelet configuration struct #7663

Closed
wants to merge 1 commit into from
Closed

Update link for kubelet configuration struct #7663

wants to merge 1 commit into from

Conversation

ashleyschuett
Copy link

@ashleyschuett ashleyschuett commented Mar 6, 2018 •
edited
Loading

The kubelet configuration file is now in beta, and the old alpha link 404s. This change updates the link to point to the beta documentation.

Update link for kubelet configuration struct
95e7d2c 
The kubelet configuration file is now in beta, and the old alpha link now 404s. This change updates the link to point to the beta documentation.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

Assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashleyschuett
Copy link
Author

/assign @zacharysara

@k8s-ci-robot
Copy link
Contributor

@ashleyschuett: GitHub didn't allow me to assign the following users: zacharysara.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @zacharysara

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 95e7d2c

https://deploy-preview-7663--kubernetes-io-master-staging.netlify.com

@mtaufen
Copy link
Contributor

mtaufen commented Mar 6, 2018

These updates already merged to the release-1.10 branch in #7561. I think master is just what shows up on the website right now, and will be updated following the release.

@ashleyschuett
Copy link
Author

@mtaufen thank you, I'll close this then.

@mtaufen
Copy link
Contributor

mtaufen commented Mar 7, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen Awaiting requested review from mtaufen

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashleyschuett @k8s-ci-robot @k8sio-netlify-preview-bot @mtaufen