Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove User FAQ refer links #5467

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Remove User FAQ refer links #5467

merged 2 commits into from
Sep 19, 2017

Conversation

kairen
Copy link

@kairen kairen commented Sep 15, 2017

Fixes issue #5462.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2017
Copy link
Contributor

@heckj heckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the other two obvious FAQ pages and if they'll be deprecated/removed as well - otherwise LGTM!

@@ -33,7 +33,6 @@ and command-line interfaces (CLIs), such as [`kubectl`](/docs/user-guide/kubectl

We also have a number of FAQ pages:

* [User FAQ](https://github.com/kubernetes/kubernetes/wiki/User-FAQ)
* [Debugging FAQ](https://github.com/kubernetes/kubernetes/wiki/Debugging-FAQ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgrant0607 question for you - in the work around kubernetes/community#116, are either of the Debugging FAQ or Services FAQ pages due to be removed as well? i.e. https://github.com/kubernetes/kubernetes/wiki/Debugging-FAQ or https://github.com/kubernetes/kubernetes/wiki/Services-FAQ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heckj All of the wiki pages need to be removed eventually. Please extend your issue or file another to ensure that content that is still relevant is moved to actual docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the community issue refers to community wiki pages. But we also need to get rid of the (even older) kubernetes/kubernetes wiki pages

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 3b8afd4

https://deploy-preview-5467--kubernetes-io-master-staging.netlify.com

@kairen
Copy link
Author

kairen commented Sep 15, 2017

@heckj Refer from @bgrant0607 comments, I removed all of the wiki refer links.

@zacharysarah zacharysarah merged commit cd67108 into kubernetes:master Sep 19, 2017
chenopis added a commit that referenced this pull request Sep 19, 2017
…hub.io into chenopis-user-journeys

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (21 commits)
  Remove User FAQ refer links (#5467)
  fix link of secret
  ZTE-SH-CN-debug-stateful-set-2017-09-19
  use para. page.version to replace specific version
  update the admission-controllers.md index.md what-is-kubernetes.md link
  Fix incorrect links
  update aggregated-api-servers.md link
  update api-group link
  fix version.md link
  Monthly 404 fix (#5494)
  Fix spelling mistake.
  Adding Treasure Data to KCSP page (#5488)
  Update docs/admin/authentication.md (#5408)
  ZTE-SH-CN-debug-pod-replication-controller-2017-09-14-14
  ZTE-SH-CN-define-command-argument-container (#5381)
  Update index.md
  Update Kompose docs
  Improve host aliases page (#5443)
  Add link to AlwaysPullImages admission controller
  Revert "create homepage for user journeys"
  ...

# Conflicts:
#	docs/home/index.md
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Remove User FAQ refer links

* Remove all of the wiki refer links
@kairen kairen deleted the patch-reference-1 branch October 3, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants