Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello minikube french #47339

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Hello minikube french #47339

merged 7 commits into from
Aug 7, 2024

Conversation

cesar-lizurey
Copy link
Contributor

Description

Getting rid of katacoda mentions in hello minikube for French language.

Issue

Closes #47214 and contributes to #41496

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 1, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added language/fr Issues or PRs related to French language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @cesar-lizurey!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c8eb5e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66abb19487a7fa00084d8d53
😎 Deploy Preview https://deploy-preview-47339--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

perriea
perriea suggested changes Aug 1, 2024
View reviewed changes
content/fr/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/fr/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/fr/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/fr/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/fr/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
@perriea
Copy link
Member

perriea commented Aug 1, 2024

@cesar-lizurey Thank you for your corrections, I will let you sign the CLA and consult my suggestions :)

@cesar-lizurey
Copy link
Contributor Author

@cesar-lizurey Thank you for your corrections, I will let you sign the CLA and consult my suggestions :)

I signed it, I don't know why it doesn't take my signature into account... :(

cesar-lizurey and others added 5 commits August 1, 2024 18:01
@cesar-lizurey @perriea
Update content/fr/docs/tutorials/hello-minikube.md
a9ef159 
Co-authored-by: Aurélien Perrier <aperrier@hartza.capital>
@cesar-lizurey @perriea
Update content/fr/docs/tutorials/hello-minikube.md
28b6ac6 
Co-authored-by: Aurélien Perrier <aperrier@hartza.capital>
@cesar-lizurey @perriea
Update content/fr/docs/tutorials/hello-minikube.md
7053515 
Co-authored-by: Aurélien Perrier <aperrier@hartza.capital>
@cesar-lizurey @perriea
Update content/fr/docs/tutorials/hello-minikube.md
9962c16 
Co-authored-by: Aurélien Perrier <aperrier@hartza.capital>
@cesar-lizurey @perriea
Update content/fr/docs/tutorials/hello-minikube.md
3c8eb5e 
Co-authored-by: Aurélien Perrier <aperrier@hartza.capital>
dipesh-rawat
dipesh-rawat reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-triggering CLA check.

/easycla

@dipesh-rawat
Copy link
Member

I signed it, I don't know why it doesn't take my signature into account... :(

The EasyCLA bot's message (here) indicates there are two commits from user djcaesar9114 (See the message below)

❌ login: @djcaesar9114 / The commit (3177ce5, bbe01fc). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

For the CLA, all contributors in the PR need to sign it. Although you've signed with @cesar-lizurey account, the check is failing because the other user (djcaesar9114) might not have signed the CLA yet.

Arhell
Arhell reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@cesar-lizurey
Copy link
Contributor Author

I submitted a ticket to EasyCLA. To be continued...

@T-Lakshmi
Copy link
Contributor

Re triggering EasyCLA to check if updated.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perriea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@perriea
Copy link
Member

perriea commented Aug 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ff02fb42249a432485afd695af28a102582506b

@k8s-ci-robot k8s-ci-robot merged commit 1d4a43b into kubernetes:main Aug 7, 2024
6 checks passed
@perriea
Copy link
Member

perriea commented Aug 7, 2024 •
edited
Loading

Congratulation for your first contribution @cesar-lizurey ! 🎉

@cesar-lizurey
Copy link
Contributor Author

Congratulation for your first contribution @cesar-lizurey ! 🎉

Thanks a lot!

@reylejano reylejano mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Arhell Arhell Arhell left review comments

@perriea perriea perriea approved these changes

@rekcah78 rekcah78 Awaiting requested review from rekcah78

Assignees

@perriea perriea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fr] Inactive and deprecated interactive tutorial in "Learn Kubernetes Basics" page
7 participants
@cesar-lizurey @k8s-ci-robot @perriea @dipesh-rawat @T-Lakshmi @Arhell @djcaesar9114