Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated korean contents in dev-1.27-ko.1 (M74-M81) #46554

Open
wants to merge 1 commit into
base: dev-1.27-ko.1
Choose a base branch
from
Open

[ko] Update outdated korean contents in dev-1.27-ko.1 (M74-M81) #46554

wants to merge 1 commit into from

Conversation

YanyChoi
Copy link

Files Checked & Modified

M74. content/en/docs/concepts/workloads/controllers/cron-jobs.md | 145(+L) 70(-)
M75. content/en/docs/concepts/workloads/controllers/daemonset.md | 52(+M) 43(-)
M76. content/en/docs/concepts/workloads/controllers/deployment.md | 394(+L) 378(-)
M77. content/en/docs/concepts/workloads/controllers/job.md | 162(+L) 121(-)
M78. content/en/docs/concepts/workloads/controllers/replicaset.md | 23(+S) 20(-)
M79. content/en/docs/concepts/workloads/controllers/replicationcontroller.md | 9(+XS) 3(-)
M80. content/en/docs/concepts/workloads/controllers/statefulset.md | 3(+XS) 3(-)
M81. content/en/docs/concepts/workloads/controllers/ttlafterfinished.md | 47(+M) 35(-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ysyukr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label May 27, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 27, 2024
@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 24319e2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66862ecfefb79b0008c25d09
😎 Deploy Preview https://deploy-preview-46554--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 24319e2
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/66862ece4458e500084a41bc
😎 Deploy Preview https://deploy-preview-46554--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jongwooo
Copy link
Member

/assign

@YanyChoi YanyChoi changed the title Update outdated korean contents in dev-1.27-ko.1 (M74-M81) [ko] Update outdated korean contents in dev-1.27-ko.1 (M74-M81) Jun 21, 2024
jongwooo
jongwooo reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanyChoi 사소한 사항들 확인해 보았습니다. 아래 리뷰 의견 참고하여 업데이트 부탁드립니다:)

content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicaset.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/ttlafterfinished.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/ttlafterfinished.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/ttlafterfinished.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
@YanyChoi
Copy link
Author

YanyChoi commented Jul 4, 2024

@jongwooo 말씀하신 부분 반영해서 수정했어요 ^_^
확인 부탁드려요. 🙇

jongwooo
jongwooo reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanyChoi 빠르게 반영해주셔서 감사합니다!

사소한 코멘트 한 가지 추가해보았습니다.
반영하시면서, squash 도 하셔서, 최종적으로 이 PR에 하나의 commit만 있도록 작업해 주시면 감사하겠습니다:)

content/ko/docs/concepts/workloads/controllers/cron-jobs.md Outdated Show resolved Hide resolved
@YanyChoi @jongwooo
Update Korean Documents 74-81
24319e2 
Apply suggestions from code review

update 74-81

translate daemonset.md version 1.27.1 to korean

translate cron-jobs.md version 1.27.1 to korean

Co-Authored-By: Jongwoo Han <jongwooo.han@gmail.com>
@YanyChoi YanyChoi force-pushed the dev-1.27-ko.1-yanychoi-74-to-81 branch from 43d3b61 to 24319e2 Compare July 4, 2024 05:10
@YanyChoi
Copy link
Author

YanyChoi commented Jul 4, 2024

@jongwooo Squash Merge로 커밋 하나로 병합했어요~ 확인 부탁드려요.

jongwooo
jongwooo reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanyChoi 고생 많으셨습니다! 감사합니다:)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02386774d8750a40e987aa085956eb7db86e5430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongwooo jongwooo jongwooo left review comments

@gochist gochist Awaiting requested review from gochist

@jmyung jmyung Awaiting requested review from jmyung

Assignees

@jongwooo jongwooo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YanyChoi @k8s-ci-robot @jongwooo