Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated files in dev-1.27-ko.1 (M244-M253) #41766

Conversation

jongwooo
Copy link
Member

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Related Issue: #41631

Updated outdated files in content/ko/examples/.

10 files to be modified

  • M244. content/en/examples/admin/konnectivity/konnectivity-agent.yaml | 1(+XS) 1(-)
  • M245. content/en/examples/admin/konnectivity/konnectivity-server.yaml | 2(+XS) 1(-)
  • M246. content/en/examples/admin/sched/my-scheduler.yaml | 14(+S) 0(-)
  • M247. content/en/examples/application/php-apache.yaml | 1(+XS) 0(-)
  • M248. content/en/examples/concepts/policy/limit-range/problematic-limit-range.yaml | 1(+XS) 0(-)
  • M249. content/en/examples/pods/inject/secret-pod.yaml | 1(+XS) 0(-)
  • M250. content/en/examples/pods/pod-with-scheduling-gates.yaml | 2(+XS) 2(-)
  • M251. content/en/examples/security/kind-with-cluster-level-baseline-pod-security.sh | 17(+S) 3(-)
  • M252. content/en/examples/security/kind-with-namespace-level-baseline-pod-security.sh | 21(+S) 7(-)
  • M253. content/en/examples/service/networking/custom-dns.yaml | 1(+XS) 1(-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 26, 2023
@jongwooo jongwooo force-pushed the 230626_ko_update_outdated_files branch from 8e8a69f to 9feb673 Compare June 26, 2023 07:30
@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 8e8a69f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/64993e96b76ea6000853bd52
😎 Deploy Preview https://deploy-preview-41766--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongwooo 감사합니다~~
영문 소스의 변경사항이 모두 반영된 것을 확인했습니다.

다만 Netlify 빌드가 실패했는데요
이 PR의 변경사항에 문제가 있지는 않은 것 같습니다.
(force-)push 를 하시면 다시 빌드를 시도해서 성공할 것 같습니다.

git commit --amend --no-edit 하면 커밋 해시만 변경되구요
이후 force-push 하면 되지 않을까 싶습니다.
(이렇게 했는데 혹시 Netlify build trigger 가 안 되면.. 다른 방법을 써야 할 것 같습니다)

Edit:
#41766 (comment) 를 보면 빌드가 성공했고 프리뷰 사이트도 올라왔습니다.
아래 GitHub UI 상황판이 잘못 나오고 있는 것 같습니다 😅
image

@jihoon-seo
Copy link
Member

/assign

@jihoon-seo
Copy link
Member

감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00a9a3e88bfbeb21aac27732a8b90681e2f99a44

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@jihoon-seo
Copy link
Member

@jongwooo Prow 가 Netlify 빌드를 실패했다고 인식하여 머지를 안 하고 있어서 (링크)
force-push 가 한번 필요할 것 같습니다. 😅

git commit --amend --no-edit 하면 커밋 해시만 변경되구요
이후 force-push 하면 되지 않을까 싶습니다.
(이렇게 했는데 혹시 Netlify build trigger 가 안 되면.. 다른 방법을 써야 할 것 같습니다)

확인 부탁드릴게요~~

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the 230626_ko_update_outdated_files branch from 9feb673 to d338a2f Compare June 26, 2023 10:30
@jongwooo
Copy link
Member Author

@jihoon-seo force-push하였습니다! 감사합니다:)

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit d338a2f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/649968bc0346840008d9b8c7
😎 Deploy Preview https://deploy-preview-41766--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot merged commit 7c1aac8 into kubernetes:dev-1.27-ko.1 Jun 26, 2023
4 checks passed
@jongwooo jongwooo deleted the 230626_ko_update_outdated_files branch June 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants