Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/concepts/storage/volumes/ #5766

Closed
1 of 2 tasks
kfox1111 opened this issue Oct 4, 2017 · 6 comments · Fixed by #6873
Closed
1 of 2 tasks

Issue with k8s.io/docs/concepts/storage/volumes/ #5766

kfox1111 opened this issue Oct 4, 2017 · 6 comments · Fixed by #6873
Assignees

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented Oct 4, 2017

This is a...

  • Feature Request
  • Bug Report

Problem:
The documentation states that the MountPropagation=true feature-gate needs to be enabled, but it is unclear where it needs to be set. Kubelet? kube-apiserver? anywhere else?

Proposed Solution:
Need to document where the flag is useful.

Page to Update:
k8s.io/docs/concepts/storage/volumes/

@zacharysarah
Copy link
Contributor

@jsafrane 👋 This looks related to #5544. Would you mind taking a look, please?

@kfox1111
Copy link
Contributor Author

kfox1111 commented Oct 5, 2017

FYI, I just got it to work. The flag was needed to be applied to the kube-apiserver and kubelet. I did not set the flag on any other services.

@jsafrane
Copy link
Member

jsafrane commented Oct 6, 2017

IMO, all features should be enabled on all components, otherwise you risk errors. Here it may be enough to enable it on API server and kubelet, but you can't be 100% sure with other features.

@kfox1111
Copy link
Contributor Author

kfox1111 commented Oct 6, 2017

I agree, but the bug report was "how do I get the mount propagation feature to work, as the documentation for it was unclear". Having the documentation be updated to be more accurate/specific I think is a good thing.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2018
@tengqm
Copy link
Contributor

tengqm commented Jan 8, 2018

/remove-lifecycle stale
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2018
tengqm added a commit to tengqm/website that referenced this issue Jan 8, 2018
For specifying mount propagation, changes to flags on apiserver and
kubelet are required. This PR fixes the problem.

For more comprehensive list of feature gate settings, please refer to
kubernetes#6364.

Closes: kubernetes#5766
steveperry-53 pushed a commit that referenced this issue Jan 8, 2018
For specifying mount propagation, changes to flags on apiserver and
kubelet are required. This PR fixes the problem.

For more comprehensive list of feature gate settings, please refer to
#6364.

Closes: #5766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants