Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from godep to modules and bump versions #287

Merged
merged 9 commits into from
Jun 5, 2019
Merged

Migrate from godep to modules and bump versions #287

merged 9 commits into from
Jun 5, 2019

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Jun 4, 2019 •
edited
Loading

This PR migrates the dependency management system from godep to modules and bumps the package versions.

Kubernetes is now using modules. See this k8s KEP. NPD is still using vendoring with modules.

The side effect of using golang modules is that it requires go 1.11+ to build node-problem-detector afterwards.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2019
@wangzhen127
Copy link
Member Author

Still work in progress.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2019
@wangzhen127 wangzhen127 changed the title Migrate from godep to modules and bump k8s version Migrate from godep to modules and bump k8s version to 1.14 Jun 4, 2019
@wangzhen127
Copy link
Member Author

This is ready for review.
/assign @andyxning
/assign @Random-Liu

@wangzhen127
Copy link
Member Author

/retest pull-npd-test

@wangzhen127
Copy link
Member Author

/cc @xueweiz

@k8s-ci-robot
Copy link
Contributor

@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: xueweiz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xueweiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127
Copy link
Member Author

/test pull-npd-test

andyxning
andyxning reviewed Jun 4, 2019
View reviewed changes
Makefile Outdated
@@ -69,7 +69,7 @@ ifeq ($(ENABLE_JOURNALD), 1)
endif

vet:
go list ./... | grep -v "./vendor/*" | xargs go vet $(BUILD_TAGS)
GO111MODULE=off go list ./... | grep -v "./vendor/*" | GO111MODULE=off xargs go vet $(BUILD_TAGS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this off?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@wangzhen127 wangzhen127 changed the title Migrate from godep to modules and bump k8s version to 1.14 Migrate from godep to modules and bump versions Jun 4, 2019
@wangzhen127
Copy link
Member Author

/retest

@wangzhen127
Copy link
Member Author

Note that I didn't bump versions of the following:

	k8s.io/api v0.0.0-20180127130940-acf347b865f2
	k8s.io/apimachinery v0.0.0-20180126010752-19e3f5aa3adc
	k8s.io/client-go v0.0.0-20180103015815-9389c055a838
	k8s.io/heapster v0.0.0-20180704153620-b25f8a16208f

I tried to bump their versions to latest. But it seems that make test will complain. I dig deeper and it is actually go vet's problem. Somehow go vet tries to check the imported vendor code, which I thought it should not do. I spent some time on it, but didn't figure out a workaround. I decide it does not worth more time to bump those packages, because they work fine now. We can look into them later when needed.

@andyxning
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyxning,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyxning
Copy link
Member

/test pull-npd-test

@andyxning
Copy link
Member

Seems flakes.
/test pull-npd-test

@k8s-ci-robot k8s-ci-robot merged commit b454a42 into kubernetes:master Jun 5, 2019
@wangzhen127 wangzhen127 deleted the bump branch June 5, 2019 15:49
@xueweiz xueweiz mentioned this pull request Jun 6, 2019
Merged
@adammw adammw mentioned this pull request Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning andyxning left review comments

@asalkeld asalkeld Awaiting requested review from asalkeld

Assignees

@andyxning andyxning

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangzhen127 @k8s-ci-robot @andyxning @Random-Liu