Support non-default docker endpoints #9510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @ilya-zuyev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
Can one of the admins verify this patch? |
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 1c3c7180-1365-11eb-8230-47bfa5f272e1 |
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: cb547af0-14f0-11eb-aff7-dd8cbeb067cc |
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: d1cfe2d0-14f4-11eb-aff7-dd8cbeb067cc |
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: a9b3f400-1597-11eb-94fa-edf6748ec8ed |
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: ec738000-18e2-11eb-86f8-31dd4df69769 |
ilya-zuyev
commented
Oct 29, 2020
ilya-zuyev
commented
Oct 29, 2020
ilya-zuyev
commented
Oct 29, 2020
ilya-zuyev
commented
Oct 29, 2020
ilya-zuyev
commented
Oct 29, 2020
afbjorklund
reviewed
Oct 29, 2020
| // TODO: comment | ||
| func DockerMachineHost(driver string) string { | ||
| // IsExternalRuntimeHost returns whether or not the OCI runtime is running on an external/virtual host | ||
| // For Podman driver it's always false for now |
There was a problem hiding this comment.
the rules for podman should be the same as for docker, when it comes to external vs. local
only the default transport differs, if it is tcp: or ssh: (as opposed to unix: for the local socket)
eventually it is going to end up looking very similar, once we get rid of the legacy protocols
then it will always be the same unix socket, possibly tunneled over a ssh connection first...
There was a problem hiding this comment.
Agreed. I just want to reduce the scope of this PR and implement support of external docker endpoints here, and later do the same for Podman.
There was a problem hiding this comment.
I am okay with adding that in a following up PR, once we add support for non default podman
Travis tests have failedHey @ilya-zuyev, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 7e3cafc0-1b1d-11eb-ae51-b75871e10011 |
ilya-zuyev
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@ilya-zuyev please ensure running |
|
kvm2 Driver |
|
kvm2 Driver Times for Minikube (PR 9510): 60.1s 55.6s 61.0s Averages Time Per Log docker Driver Times for Minikube (PR 9510): 29.1s 28.1s 28.1s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9510): 70.3s 69.2s 72.1s Averages Time Per Log docker Driver Times for Minikube (PR 9510): 43.0s 43.4s 45.6s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9510): 71.7s 75.1s 73.2s Averages Time Per Log docker Driver Times for Minikube (PR 9510): 43.4s 44.1s 42.1s Averages Time Per Log |
Codecov Report
@@ Coverage Diff @@
## master #9510 +/- ##
==========================================
+ Coverage 29.47% 29.76% +0.29%
==========================================
Files 173 174 +1
Lines 10736 10835 +99
==========================================
+ Hits 3164 3225 +61
- Misses 7123 7155 +32
- Partials 449 455 +6
|
medyagh
approved these changes
Nov 17, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ilya-zuyev, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9463
This PR adds support of non-default docker configurations, defined by environment valirables DOCKER_HOST, DOCKER_CERT_PATH, and DOCKER_TLS_VERIFY.
Right now docker driver always uses the default values, and does not support docker damon runnig on external/VM host, or local docker daemon running on unix socker other that /var/run/docker.sock
Tested on Linux docker machine:
Before:
After:
the
docker-envcommand updated to save the original environment if set, and restore it back on--unset