Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable swap in Docker & podman containers #9149

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Sep 1, 2020

This fixes the performance degradation issues seen when Docker is used with limited RAM.

For example, with 1GB allocated to Docker Desktop, minikube suffers a ~28% performance hit without this PR. With this PR, it performs the same as if there was 4GB of memory.

NOTE: The Docker kernel will still swap, and swap will still show up in free, as it is not cgroups aware. This merely keeps processes launched within minikube container from swapping.

Related PR: #9144

Fixes: #8892 by ensuring that Docker has the same performance characteristics as our ISO -- less RAM does not make it slower.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2020
@tstromberg tstromberg changed the title Disable swap in Docker/podman by setting --memory-swap to --memory Disable swap in Docker & podman containers Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 1, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9149): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9149/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9149/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9149): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9149/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9149/minikube: exec format error

@tstromberg tstromberg merged commit 914f10b into kubernetes:master Sep 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if Docker is likely to encounter swap issues (performance impact)
4 participants