Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: Quiet initial ssh timeout warning #8027

Merged
merged 2 commits into from
May 8, 2020
Merged

virtualbox: Quiet initial ssh timeout warning #8027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32e4e64
Quiet initial ssh timeout message
tstromberg May 7, 2020
68cd6f9
Merge branch 'master' into quiet-ssh2
tstromberg May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/node/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ func trySSH(h *host.Host, ip string) error {
d := net.Dialer{Timeout: 3 * time.Second}
conn, err := d.Dial("tcp", sshAddr)
if err != nil {
out.WarningT("Unable to verify SSH connectivity: {{.error}}. Will retry...", out.V{"error": err})
glog.Warningf("dial failed (will retry): %v", err)
Copy link
Member

@medyagh medyagh May 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this only causes UI trouble on virtualbox what if we supress UI error only for virtualbox driver? and let other drivers bug us if that happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like adding another branch would be over-complicating things with little benefit. If it fails later, an error will be emitted by the ssh runner.

return err
}
_ = conn.Close()
Expand Down
3 changes: 0 additions & 3 deletions test/integration/error_spam_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ var stderrWhitelist = []string{
`slow|long time|Restarting the docker service may improve`,
// don't care if we can't push images to other profiles
`cache_images.go:.*error getting status`,
// network flakiness on VirtualBox
// ! Unable to verify SSH connectivity: dial tcp 192.168.99.249:22: i/o timeout. Will retry...
`SSH.*i/o timeout.retry`,
}

// stderrWhitelistRe combines rootCauses into a single regex
Expand Down