Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable or disable addons per profile #6124

Merged
merged 19 commits into from
Jan 7, 2020
Merged

Enable or disable addons per profile #6124

merged 19 commits into from
Jan 7, 2020

Commits on Dec 18, 2019

  1. Move addon related logic to pkg/addons for better organization

    Priya Wadhwa committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    ba8b723 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Enable/disable addons works per profile 

    However, this means that addon information won't persist beyond a 'minikube delete'
    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    e72cb80 View commit details
    Browse the repository at this point in the history

  2. Moved unit tests to addons package and refactored them

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    921fee7 View commit details
    Browse the repository at this point in the history

  3. Add more unit tests

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    ceb4938 View commit details
    Browse the repository at this point in the history

  4. make public methods that aren't used outside of the package private

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    43a7267 View commit details
    Browse the repository at this point in the history

  5. Address review comments 

    Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    4c7b949 View commit details
    Browse the repository at this point in the history

  6. Make sure minikube start --addons works

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    f6c61b7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:kubernetes/minikube into addon-pe… 

    …r-profile-refactor
    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    859420c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:kubernetes/minikube into addon-pe… 

    …r-profile-refactor
    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    83aca57 View commit details
    Browse the repository at this point in the history

  9. goimports

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    fa08e18 View commit details
    Browse the repository at this point in the history

  10. updated dashboard command to use new addons library

    Priya Wadhwa committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    b64a33a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. increase wait times for pods, virtualbox integration test was timing out

    Priya Wadhwa committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    2f50957 View commit details
    Browse the repository at this point in the history

  2. Rebased on master

    Priya Wadhwa committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    6c25cd3 View commit details
    Browse the repository at this point in the history

  3. try running addons test in sequence, since parallel test seems to be … 

    …failing on virtualbox
    Priya Wadhwa committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    81a2c16 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Rebased on master, moved istio addon into new package

    Priya Wadhwa committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    e47cde6 View commit details
    Browse the repository at this point in the history

  2. Parallelize test again, running locally with virtualbox on macOS was … 

    …successful
    Priya Wadhwa committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    1126f26 View commit details
    Browse the repository at this point in the history

  3. update gvisor addon test now that addons are per profile

    Priya Wadhwa committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    44cde77 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Don't run TestAddons in parallel with other tests, virtualbox on linu… 

    …x complains
    Priya Wadhwa committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    885ec3c View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. address code review comments 

    add better error handling and remove duplication in enableOrDisableAddonsInternal
    Priya Wadhwa committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    6ad7e4a View commit details
    Browse the repository at this point in the history